Re: [PATCH 2/7] nfsd4: edit comment for concision

[Chuck Lever <chuck.lever@oracle.com>]

On 03/02/2010 06:12 PM, J. Bruce Fields wrote:
> Also note units are seconds.

I'd prefer the major edits in this patch be done at the same time you 
trim the other documenting comments for the /proc/fs/nfsd API.

> Signed-off-by: J. Bruce Fields<bfields@citi.umich.edu>
> ---
>   fs/nfsd/nfsctl.c |   21 ++++++---------------
>   1 files changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 8bff674..f1ee549 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1228,23 +1228,14 @@ static ssize_t __write_leasetime(struct file *file, char *buf, size_t size)
>   /**
>    * write_leasetime - Set or report the current NFSv4 lease time
>    *
> - * Input:
> - *			buf:		ignored
> - *			size:		zero
> + * If given a nonzero size, sets the NFSv4 lease time to a number of
> + * seconds (interpreting buf as a C string containing an ascii
> + * representation of the number).
>    *
> - * OR
> + * Returns the resulting lease time (as an ascii representation in a
> + * '\n'-terminated C string) in buf.
>    *
> - * Input:
> - *			buf:		C string containing an unsigned
> - *					integer value representing the new
> - *					NFSv4 lease expiry time
> - *			size:		non-zero length of C string in @buf
> - * Output:
> - *	On success:	passed-in buffer filled with '\n'-terminated C
> - *			string containing unsigned integer value of the
> - *			current lease expiry time;
> - *			return code is the size in bytes of the string
> - *	On error:	return code is zero or a negative errno value
> + * Given a zero size, just returns the lease time in buf.
>    */
>   static ssize_t write_leasetime(struct file *file, char *buf, size_t size)
>   {


-- 
chuck[dot]lever[at]oracle[dot]com