From: Steve Dickson <SteveD@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mountd: fix --manage-gids hang due to int/uint bug
Date: Mon, 08 Mar 2010 11:23:56 -0500 [thread overview]
Message-ID: <4B95249C.9020306@RedHat.com> (raw)
In-Reply-To: <20100302204930.GA8609@fieldses.org>
On 03/02/2010 03:49 PM, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@citi.umich.edu>
>
> A uid or gid should be represented as unsigned, not signed.
>
> The conversion to signed here could cause a hang on access by an unknown
> user to a server running mountd with --manage-gids; such a user is
> likely to be mapped to 232-1, which may be converted to 231-1 when
> represented as an int, resulting in a downcall for uid 231-1, hence the
> original rpc hanging forever waiting for a cache downcall for 232-1.
>
> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Committed...
steved.
next prev parent reply other threads:[~2010-03-08 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 20:49 [PATCH] mountd: fix --manage-gids hang due to int/uint bug J. Bruce Fields
2010-03-08 16:23 ` Steve Dickson [this message]
[not found] ` <4B95249C.9020306-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-08 16:28 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B95249C.9020306@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox