From: Chuck Lever <chuck.lever@oracle.com>
To: Steve Dickson <SteveD@redhat.com>, Mike Frysinger <vapier@gentoo.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] make capabilities support optional
Date: Fri, 23 Apr 2010 13:28:10 -0400 [thread overview]
Message-ID: <4BD1D8AA.4030708@oracle.com> (raw)
In-Reply-To: <4BD1CADD.4050200-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
On 04/23/2010 12:29 PM, Steve Dickson wrote:
> On 04/20/2010 04:46 AM, Mike Frysinger wrote:
>> The new code using libcap is quite minor, so rather than always reqiure
>> libcap support, make it a normal --enable type flag. Current default
>> behavior is retained -- if libcap is found, it is enabled, else it is
>> disabled like every nfs-utils version in the past.
>>
>> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
>>
> Committed...
I somehow missed this one. Why are we disabling libcap? And why are we
adding another --enable flag when everyone has agreed that we should
avoid that if at all possible?
It is especially on older systems that nfs-utils will break without
libcap support. Without CAP_NET_BIND, pmap_unregister() will fail when
statd is shut down, leaving NSM registered with the portmapper, but with
no active listeners. When statd is started up again, it won't be able
to register the new NSM listener ports.
That's the bug that was fixed by the addition of libcap. I don't agree
that is "quite minor."
--
chuck[dot]lever[at]oracle[dot]com
next prev parent reply other threads:[~2010-04-23 17:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 8:46 [PATCH] make capabilities support optional Mike Frysinger
2010-04-23 16:29 ` Steve Dickson
[not found] ` <4BD1CADD.4050200-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-04-23 17:28 ` Chuck Lever [this message]
2010-04-23 18:22 ` Steve Dickson
[not found] ` <4BD1E55B.2090703-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-04-23 19:12 ` Chuck Lever
2010-04-23 19:29 ` Mike Frysinger
2010-04-23 20:09 ` Chuck Lever
2010-04-24 4:42 ` Mike Frysinger
2010-04-26 15:12 ` Chuck Lever
2010-04-26 16:46 ` Mike Frysinger
2010-04-26 18:03 ` Chuck Lever
2010-04-23 22:22 ` Steve Dickson
[not found] ` <4BD21DA1.4000001-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-04-26 15:24 ` Chuck Lever
2010-04-26 16:10 ` Steve Dickson
[not found] ` <4BD5BAD8.5040209-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-04-26 16:51 ` Mike Frysinger
2010-04-26 16:54 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD1D8AA.4030708@oracle.com \
--to=chuck.lever@oracle.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).