Re: [PATCH 3/3] SQUASHME: spnfs: fixup LAYOUT_NFSV4_1_FILES

[Boaz Harrosh <bharrosh@panasas.com>]

On 05/25/2010 08:56 AM, Benny Halevy wrote:
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> ---
>  fs/nfsd/spnfs_ops.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/spnfs_ops.c b/fs/nfsd/spnfs_ops.c
> index 230fb59..b97a5af 100644
> --- a/fs/nfsd/spnfs_ops.c
> +++ b/fs/nfsd/spnfs_ops.c
> @@ -57,7 +57,7 @@ extern struct spnfs *global_spnfs;
>  int
>  spnfs_layout_type(struct super_block *sb)
>  {
> -	return LAYOUT_NFSV4_FILES;
> +	return LAYOUT_NFSV4_1_FILES;
>  }
>  
>  enum nfsstat4
> @@ -218,7 +218,7 @@ spnfs_layoutrecall(struct inode *inode, int type, u64 offset, u64 len)
>  	}
>  
>  	lr.cbl_recall_type = type;
> -	lr.cbl_seg.layout_type = LAYOUT_NFSV4_FILES;
> +	lr.cbl_seg.layout_type = LAYOUT_NFSV4_1_FILES;
>  	lr.cbl_seg.clientid = 0;
>  	lr.cbl_seg.offset = offset;
>  	lr.cbl_seg.length = len;

Sorry to bother you guys but I don't like the "_" between the 4 and the 1
I would mutch prefer the LAYOUT_NFSV41_FILES format. An "_" is an heavy wait
that should not be used lightly.

Boaz