From: Benny Halevy <bhalevy@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] SQUASHME: pnfs-submit: avoid NULL dereference in filelayout_commit dprintk
Date: Mon, 14 Jun 2010 20:07:24 -0400 [thread overview]
Message-ID: <4C16C43C.4090107@panasas.com> (raw)
In-Reply-To: <1276455986-15911-1-git-send-email-iisaman@netapp.com>
Merged at pnfs-all-2.6.35-rc3-2010-06-14
Thanks!
Benny
On Jun. 13, 2010, 15:06 -0400, Fred Isaman <iisaman@netapp.com> wrote:
> ds_nfs_client will be NULL when filelayout_commit is called.
>
> Signed-off-by: Fred Isaman <iisaman@netapp.com>
> ---
> fs/nfs/nfs4filelayout.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
> index b82e4ff..e6d45b8 100644
> --- a/fs/nfs/nfs4filelayout.c
> +++ b/fs/nfs/nfs4filelayout.c
> @@ -569,8 +569,7 @@ filelayout_commit(struct pnfs_layout_type *layoutid, int sync,
> struct nfs_write_data *dsdata;
> struct nfs4_pnfs_ds *ds;
>
> - dprintk("%s data %p pnfs_client %p sync %d\n",
> - __func__, data, data->fldata.ds_nfs_client->cl_rpcclient, sync);
> + dprintk("%s data %p sync %d\n", __func__, data, sync);
>
> /* Alloc room for both in one go */
> ds_page_list = kzalloc((NFS4_PNFS_MAX_MULTI_CNT + 1) *
prev parent reply other threads:[~2010-06-15 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 19:06 [PATCH 1/1] SQUASHME: pnfs-submit: avoid NULL dereference in filelayout_commit dprintk Fred Isaman
2010-06-15 0:07 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C16C43C.4090107@panasas.com \
--to=bhalevy@panasas.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox