linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] pnfs-post-submit: Revert "pnfs-submit: Remove unused encode_getattr_three code"
Date: Fri, 18 Jun 2010 17:19:22 -0400	[thread overview]
Message-ID: <4C1BE2DA.5020206@panasas.com> (raw)
In-Reply-To: <1276736809-9423-2-git-send-email-iisaman@netapp.com>

Yeah.  This actually belongs to the pnfs-block branch.
I'll move it there.

Benny

On Jun. 16, 2010, 21:06 -0400, Fred Isaman <iisaman@netapp.com> wrote:
> ---
>  fs/nfs/nfs4xdr.c |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 9ef0f0a..c0bdb60 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -1060,6 +1060,35 @@ static void encode_getattr_two(struct xdr_stream *xdr, uint32_t bm0, uint32_t bm
>  	hdr->replen += decode_getattr_maxsz;
>  }
>  
> +static void
> +encode_getattr_three(struct xdr_stream *xdr,
> +		     uint32_t bm0, uint32_t bm1, uint32_t bm2,
> +		     struct compound_hdr *hdr)
> +{
> +	__be32 *p;
> +
> +	p = reserve_space(xdr, 4);
> +	*p = cpu_to_be32(OP_GETATTR);
> +	if (bm2) {
> +		p = reserve_space(xdr, 16);
> +		*p++ = cpu_to_be32(3);
> +		*p++ = cpu_to_be32(bm0);
> +		*p++ = cpu_to_be32(bm1);
> +		*p = cpu_to_be32(bm2);
> +	} else if (bm1) {
> +		p = reserve_space(xdr, 12);
> +		*p++ = cpu_to_be32(2);
> +		*p++ = cpu_to_be32(bm0);
> +		*p = cpu_to_be32(bm1);
> +	} else {
> +		p = reserve_space(xdr, 8);
> +		*p++ = cpu_to_be32(1);
> +		*p = cpu_to_be32(bm0);
> +	}
> +	hdr->nops++;
> +	hdr->replen += decode_getattr_maxsz;
> +}
> +
>  static void encode_getfattr(struct xdr_stream *xdr, const u32* bitmask, struct compound_hdr *hdr)
>  {
>  	encode_getattr_two(xdr, bitmask[0] & nfs4_fattr_bitmap[0],

      reply	other threads:[~2010-06-18 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17  1:06 [PATCH 1/2] pnfs-submit: Remove unused encode_getattr_three code Fred Isaman
2010-06-17  1:06 ` [PATCH 2/2] pnfs-post-submit: Revert "pnfs-submit: Remove unused encode_getattr_three code" Fred Isaman
2010-06-18 21:19   ` Benny Halevy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1BE2DA.5020206@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).