public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: eanderle@umich.edu
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] pnfs: Fix num_ds bug in nfsd4_set_pnfs_dlm_device()
Date: Fri, 18 Jun 2010 17:23:48 -0400	[thread overview]
Message-ID: <4C1BE3E4.2040007@panasas.com> (raw)
In-Reply-To: <1276876558.1796.19.camel@Berlin>

Merged at pnfs-all-2.6.35-rc3-2010-06-18

On Jun. 18, 2010, 11:55 -0400, Eric Anderle <eanderle@umich.edu> wrote:
>>From cd18db8401e1df4ee031e6a6c53e0f3353080dca Mon Sep 17 00:00:00 2001
> From: Eric Anderle <eanderle@umich.edu>
> Date: Fri, 18 Jun 2010 10:09:46 -0400
> Subject: [PATCH 1/1] pnfs: Fix num_ds bug in nfsd4_set_pnfs_dlm_device()

Oh, and one more nit :)
since this patch is for the server, our convention is to prefix
its subject with "pnfsd:", not "pnfs:"

Thanks!

Benny

> 
> Previously, when updating the DS list of an existing pnfs dlm device,
> the number of ds's was not updated. Fixed.
> 
> Signed-off-by: Eric Anderle <eanderle@umich.edu>
> ---
>  fs/nfsd/nfs4pnfsdlm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4pnfsdlm.c b/fs/nfsd/nfs4pnfsdlm.c
> index 40f9b84..ffe1c32 100644
> --- a/fs/nfsd/nfs4pnfsdlm.c
> +++ b/fs/nfsd/nfs4pnfsdlm.c
> @@ -189,6 +189,7 @@ nfsd4_set_pnfs_dlm_device(char *pnfs_dlm_device, int len)
>  			found->disk_name, found->ds_list, new->ds_list);
>  		memset(found->ds_list, 0, DISK_NAME_LEN);
>  		memcpy(found->ds_list, new->ds_list, strlen(new->ds_list));
> +		found->num_ds = new->num_ds;
>  		kfree(new);
>  	} else {
>  		dprintk("%s Adding pnfs_dlm_device %s:%s\n", __func__,


      reply	other threads:[~2010-06-18 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 15:55 [PATCH 1/1] pnfs: Fix num_ds bug in nfsd4_set_pnfs_dlm_device() Eric Anderle
2010-06-18 21:23 ` Benny Halevy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1BE3E4.2040007@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=bfields@fieldses.org \
    --cc=eanderle@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox