linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fix memcmp result comparison error for uuid match.
@ 2010-07-01  9:43 Doug Nazar
  2010-07-19 15:00 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Doug Nazar @ 2010-07-01  9:43 UTC (permalink / raw)
  To: linux-nfs

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

  Small typo in the new fs uuid comparison code.


[-- Attachment #2: nfs-utils-fsuuid-memcmp.diff --]
[-- Type: text/plain, Size: 606 bytes --]

commit 361f6d6c5da3c5c5ba709f8f3704865b0f7267cc
Author: Doug Nazar <nazard.michi@gmail.com>
Date:   Thu Jul 1 05:37:23 2010 -0400

    Fix memcmp result comparison error for uuid match.

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 9e1b164..bf18a9a 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -513,7 +513,7 @@ void nfsd_fh(FILE *f)
 					for (type = 0;
 					     uuid_by_path(path, type, uuidlen, u);
 					     type++)
-						if (memcmp(u, fhuuid, uuidlen) != 0)
+						if (memcmp(u, fhuuid, uuidlen) == 0)
 							break;
 
 				if (memcmp(u, fhuuid, uuidlen) != 0)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Fix memcmp result comparison error for uuid match.
  2010-07-01  9:43 Fix memcmp result comparison error for uuid match Doug Nazar
@ 2010-07-19 15:00 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2010-07-19 15:00 UTC (permalink / raw)
  To: Doug Nazar; +Cc: linux-nfs



On 07/01/2010 05:43 AM, Doug Nazar wrote:
>  Small typo in the new fs uuid comparison code.
> 
Committed....

steved.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-19 15:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-01  9:43 Fix memcmp result comparison error for uuid match Doug Nazar
2010-07-19 15:00 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).