From: Steve Dickson <SteveD@redhat.com>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: Jim Rees <rees@umich.edu>, linux-nfs@vger.kernel.org
Subject: Re: nfs-utils atomicio.c
Date: Mon, 19 Jul 2010 11:33:08 -0400 [thread overview]
Message-ID: <4C447034.4020006@RedHat.com> (raw)
In-Reply-To: <1279319622.8180.2.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>
On 07/16/2010 06:33 PM, David P. Quigley wrote:
> On Fri, 2010-07-16 at 18:06 -0400, Jim Rees wrote:
>> Steve Dickson wrote:
>>
>> > strlcat and strlcpy should probably go too.
>> Anything else?
>>
>> I don't see any other library functions that should move. Configure should
>> check for strlcat and strlcpy, and not compile them if there are system
>> versions. Again, I'll do that if no one beats me to it.
>>
>> On a related note, I've been using benny's pnfs-nfs-utils.git tree as a base
>> for adding the block layout helper, as suggested by the wiki. Is that
>> correct?
>
> Just got back from dinner and I'm heading out soon for the weekend but
> here is the patch that I have. It should apply on top of
> 2ef57222b10a91f4b96a06808d05a47e8f4c14f7 and moves strlcat and strlcpy
> as well. The only think you might have to check is I know at some point
> some changes were made to cfg.c and cfg.h make sure the ones I have in
> this patch are the new ones instead of the old ones. I'd take a closer
> look but I'm short on time here.
>
>
Question: Is there a reason need a private version of queue.h, instead
of using the one ins /usr/include/sys?
steved.
next prev parent reply other threads:[~2010-07-19 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 19:35 nfs-utils atomicio.c Jim Rees
[not found] ` <20100716193508.GA14878-8f4Pc2RrbJmHXe+LvDLADg@public.gmane.org>
2010-07-16 20:09 ` David P. Quigley
[not found] ` <1279310952.8180.0.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>
2010-07-16 20:53 ` Jim Rees
[not found] ` <20100716205355.GA7962-8f4Pc2RrbJmHXe+LvDLADg@public.gmane.org>
2010-07-16 21:02 ` Steve Dickson
[not found] ` <4C40C8DF.8030107-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-07-16 22:06 ` Jim Rees
[not found] ` <20100716220609.GA7828-8f4Pc2RrbJmHXe+LvDLADg@public.gmane.org>
2010-07-16 22:33 ` David P. Quigley
[not found] ` <1279319622.8180.2.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>
2010-07-19 15:28 ` Steve Dickson
2010-07-19 15:33 ` Steve Dickson [this message]
[not found] ` <4C447034.4020006-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-07-19 16:30 ` David P. Quigley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C447034.4020006@RedHat.com \
--to=steved@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox