From: Chuck Lever <chuck.lever@oracle.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Jeff Layton <jlayton@redhat.com>
Subject: Re: write_ports delfd case
Date: Mon, 19 Jul 2010 15:32:57 -0400 [thread overview]
Message-ID: <4C44A869.4030504@oracle.com> (raw)
In-Reply-To: <20100719192158.GC9657@fieldses.org>
On 07/19/10 03:21 PM, J. Bruce Fields wrote:
> Does anyone know what __write_ports_delfd() is meant to do?
>
> The block comment above write_ports claims it handles writes of the form
> "-<file descriptor>", which makes no sense (the file table of the writer
> has nothing to do with anything). It's called only when the character
> after the "-" is a digit, but the names it matches against (generated by
> svc_one_sock_name()) start with "ipv4" or "ipv6".
I suspect the comment above write_ports() is not correct. I assumed
that delfd was symmetrical with addfd, but it isn't. More likely, addfd
returns a string name that can be passed to write_ports (with a
preceding '-') to terminate the socket.
next prev parent reply other threads:[~2010-07-19 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 19:21 write_ports delfd case J. Bruce Fields
2010-07-19 19:32 ` Chuck Lever [this message]
2010-07-19 20:07 ` Jeff Layton
[not found] ` <20100719160703.1e686a74-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-07-19 23:41 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C44A869.4030504@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).