From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chuck Lever Subject: Re: write_ports delfd case Date: Mon, 19 Jul 2010 15:32:57 -0400 Message-ID: <4C44A869.4030504@oracle.com> References: <20100719192158.GC9657@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: Neil Brown , Linux NFS Mailing List , Jeff Layton To: "J. Bruce Fields" Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:17106 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966589Ab0GSTfO (ORCPT ); Mon, 19 Jul 2010 15:35:14 -0400 In-Reply-To: <20100719192158.GC9657@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On 07/19/10 03:21 PM, J. Bruce Fields wrote: > Does anyone know what __write_ports_delfd() is meant to do? > > The block comment above write_ports claims it handles writes of the form > "-", which makes no sense (the file table of the writer > has nothing to do with anything). It's called only when the character > after the "-" is a digit, but the names it matches against (generated by > svc_one_sock_name()) start with "ipv4" or "ipv6". I suspect the comment above write_ports() is not correct. I assumed that delfd was symmetrical with addfd, but it isn't. More likely, addfd returns a string name that can be passed to write_ports (with a preceding '-') to terminate the socket.