From: Chuck Lever <chuck.lever@oracle.com>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 08/24] Removed warnings from mountd.c
Date: Wed, 21 Jul 2010 13:23:52 -0400 [thread overview]
Message-ID: <4C472D28.6050608@oracle.com> (raw)
In-Reply-To: <1279669057-17509-9-git-send-email-steved@redhat.com>
Hi Steve-
On 07/20/10 07:37 PM, Steve Dickson wrote:
> mountd.c: In function 'mount_null_1_svc':
> mountd.c:195: warning: unused parameter 'rqstp'
> mountd.c:195: warning: unused parameter 'argp'
> mountd.c:195: warning: unused parameter 'resp'
> mountd.c: In function 'mount_dump_1_svc':
> mountd.c:213: warning: unused parameter 'argp'
> mountd.c: In function 'mount_umnt_1_svc':
> mountd.c:224: warning: unused parameter 'resp'
> mountd.c: In function 'mount_umntall_1_svc':
> mountd.c:248: warning: unused parameter 'argp'
> mountd.c:248: warning: unused parameter 'resp'
> mountd.c: In function 'mount_export_1_svc':
> mountd.c:258: warning: unused parameter 'argp'
> mountd.c: In function 'mount_exportall_1_svc':
> mountd.c:269: warning: unused parameter 'argp'
> mountd.c: In function 'mount_dump_1_svc':
> mountd.c:216: warning: unused parameter 'argp'
> mountd.c: In function 'mount_umnt_1_svc':
> mountd.c:227: warning: unused parameter 'resp'
> mountd.c: In function 'mount_umntall_1_svc':
> mountd.c:251: warning: unused parameter 'argp'
> mountd.c:251: warning: unused parameter 'resp'
> mountd.c: In function 'mount_export_1_svc':
> mountd.c:261: warning: unused parameter 'argp'
> mountd.c: In function 'mount_exportall_1_svc':
> mountd.c:272: warning: unused parameter 'argp'
>
> Signed-off-by: Steve Dickson<steved@redhat.com>
> ---
> utils/mountd/mountd.c | 19 +++++++++++++++----
> 1 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index 6571454..43aec11 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -194,6 +194,9 @@ sig_hup (int sig)
> bool_t
> mount_null_1_svc(struct svc_req *rqstp, void *argp, void *resp)
> {
> + xlog(D_CALL, "MNT1(%s) null: rqstp %p argp %p resp %p",
> + rqstp, argp, resp);
> +
> return 1;
> }
>
> @@ -214,7 +217,8 @@ mount_dump_1_svc(struct svc_req *rqstp, void *argp, mountlist *res)
> {
> struct sockaddr_in *addr = nfs_getrpccaller_in(rqstp->rq_xprt);
>
> - xlog(D_CALL, "dump request from %s.", inet_ntoa(addr->sin_addr));
> + xlog(D_CALL, "MNT1(%s) dump request: argp %p",
> + inet_ntoa(addr->sin_addr), argp);
> *res = mountlist_list();
>
> return 1;
> @@ -235,6 +239,8 @@ mount_umnt_1_svc(struct svc_req *rqstp, dirpath *argp, void *resp)
> rpath[sizeof (rpath) - 1] = '\0';
> p = rpath;
> }
> + xlog(D_CALL, "MNT1(%s) unmount: path %s resp %p",
> + inet_ntoa(sin->sin_addr), p, resp);
I have to agree with Bruce: adding xlog() calls here is the wrong thing
to do. Instead, use
__attribute__((unused))
for the unused parameters.
> if (!(exp = auth_authenticate("unmount", sin, p))) {
> return 1;
> @@ -247,10 +253,15 @@ mount_umnt_1_svc(struct svc_req *rqstp, dirpath *argp, void *resp)
> bool_t
> mount_umntall_1_svc(struct svc_req *rqstp, void *argp, void *resp)
> {
> + struct sockaddr_in *sin = nfs_getrpccaller_in(rqstp->rq_xprt);
> +
> + xlog(D_CALL, "UMNT1(%s) unmountall: argp %s resp %p",
> + inet_ntoa(sin->sin_addr), argp, resp);
> +
> /* Reload /etc/xtab if necessary */
> auth_reload();
>
> - mountlist_del_all(nfs_getrpccaller_in(rqstp->rq_xprt));
> + mountlist_del_all(sin);
You couldn't wait until the rest of my IPv6 mountd patches are
integrated? I address a lot of these problems in those patches, and now
I'm going to have to rebase all of that work. What's the rush?
> return 1;
> }
>
> @@ -259,7 +270,7 @@ mount_export_1_svc(struct svc_req *rqstp, void *argp, exports *resp)
> {
> struct sockaddr_in *addr = nfs_getrpccaller_in(rqstp->rq_xprt);
>
> - xlog(D_CALL, "export request from %s.", inet_ntoa(addr->sin_addr));
> + xlog(D_CALL, "EXPORT(%s) dump: argp %p", inet_ntoa(addr->sin_addr), argp);
> *resp = get_exportlist();
>
> return 1;
> @@ -270,7 +281,7 @@ mount_exportall_1_svc(struct svc_req *rqstp, void *argp, exports *resp)
> {
> struct sockaddr_in *addr = nfs_getrpccaller_in(rqstp->rq_xprt);
>
> - xlog(D_CALL, "exportall request from %s.", inet_ntoa(addr->sin_addr));
> + xlog(D_CALL, "EXPORTALL(%s) dump: argp %p", inet_ntoa(addr->sin_addr), argp);
> *resp = get_exportlist();
>
> return 1;
next prev parent reply other threads:[~2010-07-21 17:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 23:37 [PATCH 00/24] Turn on the -Wextra compile flag Steve Dickson
2010-07-20 23:37 ` [PATCH 01/24] Enable extra compile warnings (-Wextra) by default Steve Dickson
2010-07-20 23:37 ` [PATCH 02/24] Remove warnings from nfsctl.c Steve Dickson
2010-07-21 17:06 ` J. Bruce Fields
2010-08-04 12:36 ` Steve Dickson
2010-07-20 23:37 ` [PATCH 03/24] Removed warnings from rpcdispatch.c Steve Dickson
2010-07-20 23:37 ` [PATCH 04/24] Remove warnings from svc_socket.c Steve Dickson
2010-07-20 23:37 ` [PATCH 05/24] emove warnings from cacheio.c Steve Dickson
2010-07-20 23:37 ` [PATCH 06/24] Remove warnings from nfs_mntent.c Steve Dickson
2010-07-20 23:37 ` [PATCH 07/24] Removed warnings from conffile.c Steve Dickson
2010-07-20 23:37 ` [PATCH 08/24] Removed warnings from mountd.c Steve Dickson
2010-07-21 17:12 ` J. Bruce Fields
2010-08-04 13:44 ` Steve Dickson
2010-07-21 17:23 ` Chuck Lever [this message]
2010-08-04 13:50 ` Steve Dickson
2010-08-04 15:57 ` Chuck Lever
2010-07-20 23:37 ` [PATCH 09/24] Removed warnings from fsloc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 10/24] Removed warnings from cache.c Steve Dickson
2010-07-20 23:37 ` [PATCH 11/24] Removed warnings from nfssvc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 12/24] Removed warnings from nfsstat.c Steve Dickson
2010-07-20 23:37 ` [PATCH 13/24] Removed warnings from atomicio.c Steve Dickson
2010-07-20 23:37 ` [PATCH 14/24] Removed warnings from idmapd.c Steve Dickson
2010-07-21 17:24 ` J. Bruce Fields
2010-07-20 23:37 ` [PATCH 15/24] Removed warnings from gssd.c Steve Dickson
2010-07-20 23:37 ` [PATCH 16/24] Removed warnings from gssd_main_loop.c Steve Dickson
2010-07-20 23:37 ` [PATCH 17/24] Removed warnings from krb5_util.c Steve Dickson
2010-07-20 23:37 ` [PATCH 18/24] Removed warnings from gssd_proc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 19/24] Removed warnings from svcgssd.c Steve Dickson
2010-07-20 23:37 ` [PATCH 20/24] Removed warnings from svcgssd_proc.c Steve Dickson
2010-07-21 17:23 ` J. Bruce Fields
2010-07-20 23:37 ` [PATCH 21/24] Removed warnings from network.c Steve Dickson
2010-07-21 17:17 ` Chuck Lever
2010-07-20 23:37 ` [PATCH 22/24] Removed warnings from nfsmount.c Steve Dickson
2010-07-20 23:37 ` [PATCH 23/24] Removed warnings from nfs4mount.c Steve Dickson
2010-07-20 23:37 ` [PATCH 24/24] Removed warnings from configfile.c Steve Dickson
2010-07-21 17:53 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C472D28.6050608@oracle.com \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).