linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Warning in kref handling + kernel hangs
@ 2010-08-02 11:51 Menyhart Zoltan
  0 siblings, 0 replies; only message in thread
From: Menyhart Zoltan @ 2010-08-02 11:51 UTC (permalink / raw)
  To: linux-nfs

Hi,

I have a warning in kref handling (e.g. in 2.6.34.1) and my kernel hangs.
Should not we miss a svc_xprt_get(xprt) in the else branch of svc_xprt_enqueue() ?

int svc_recv(struct svc_rqst *rqstp, long timeout)
{
...
	xprt = svc_xprt_dequeue(pool);
	if (xprt) {
		rqstp->rq_xprt = xprt;
		svc_xprt_get(xprt);  //WARNING: at lib/kref.c:43 kref_get+0x23/0x2d()


void svc_xprt_enqueue(struct svc_xprt *xprt)
{
...
         if (!list_empty(&pool->sp_threads)) {
...
                 svc_xprt_get(xprt);
...
                 wake_up(&rqstp->rq_wait);
         } else {
                 list_add_tail(&xprt->xpt_ready, &pool->sp_sockets);
                 pool->sp_stats.sockets_queued++;
         }

Thanks,

Zoltan Menyhart

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-02 12:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-02 11:51 Warning in kref handling + kernel hangs Menyhart Zoltan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).