From: Bian Naimeng <biannm@cn.fujitsu.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 2/2] We should clear NFS_DELEGATED_STATE after return delegation
Date: Wed, 04 Aug 2010 17:18:34 +0800 [thread overview]
Message-ID: <4C59306A.9090302@cn.fujitsu.com> (raw)
In-Reply-To: <4C592F85.8070308@cn.fujitsu.com>
We should clear NFS_DELEGATED_STATE bit for inode->open_states after return delegation.
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
fs/nfs/nfs4proc.c | 15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 70015dd..76cdef4 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -933,16 +933,29 @@ no_delegation:
static void nfs4_return_incompatible_delegation(struct inode *inode, fmode_t fmode)
{
+ struct nfs_inode *nfsi = NFS_I(inode);
struct nfs_delegation *delegation;
+ struct nfs4_state *state;
rcu_read_lock();
- delegation = rcu_dereference(NFS_I(inode)->delegation);
+ delegation = rcu_dereference(nfsi->delegation);
if (delegation == NULL || (delegation->type & fmode) == fmode) {
rcu_read_unlock();
return;
}
rcu_read_unlock();
nfs_inode_return_delegation(inode);
+
+ spin_lock(&inode->i_lock);
+ list_for_each_entry(state, &nfsi->open_states, inode_states) {
+ if (state->owner == NULL)
+ continue;
+
+ spin_lock(&state->owner->so_lock);
+ clear_bit(NFS_DELEGATED_STATE, &state->flags);
+ spin_unlock(&state->owner->so_lock);
+ }
+ spin_unlock(&inode->i_lock);
}
static struct nfs4_state *nfs4_try_open_cached(struct nfs4_opendata *opendata)
--
1.6.5.2
next prev parent reply other threads:[~2010-08-04 9:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 9:14 [PATCH 0/2] Fix bug that client use a invaild delegation Bian Naimeng
2010-08-04 9:15 ` [PATCH 1/2] Make lock inode before lock nfs4_state_owner Bian Naimeng
2010-08-04 9:18 ` Bian Naimeng [this message]
2010-08-04 12:45 ` [PATCH 2/2] We should clear NFS_DELEGATED_STATE after return delegation Trond Myklebust
2010-08-05 2:26 ` Bian Naimeng
2010-08-05 13:03 ` Trond Myklebust
2010-08-06 4:10 ` Bian Naimeng
2010-08-06 13:30 ` Trond Myklebust
2010-08-16 7:50 ` Bian Naimeng
2010-08-17 23:16 ` Trond Myklebust
2010-08-18 3:17 ` Bian Naimeng
2010-08-23 7:43 ` Bian Naimeng
2010-09-01 6:40 ` Bian Naimeng
2010-09-07 22:04 ` Trond Myklebust
2010-09-08 1:33 ` Bian Naimeng
2010-09-08 1:57 ` Trond Myklebust
2010-09-08 2:37 ` Bian Naimeng
2010-09-08 3:11 ` Bian Naimeng
2010-09-08 20:37 ` Trond Myklebust
2010-09-09 1:29 ` Bian Naimeng
2010-11-24 6:27 ` Bian Naimeng
[not found] ` <1283978245.2905.23.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-12-02 8:32 ` Li Yewang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C59306A.9090302@cn.fujitsu.com \
--to=biannm@cn.fujitsu.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).