From: Steve Dickson <SteveD@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 02/24] Remove warnings from nfsctl.c
Date: Wed, 04 Aug 2010 08:36:19 -0400 [thread overview]
Message-ID: <4C595EC3.2040500@RedHat.com> (raw)
In-Reply-To: <20100721170646.GA26418@fieldses.org>
On 07/21/2010 01:06 PM, J. Bruce Fields wrote:
> On Tue, Jul 20, 2010 at 07:37:15PM -0400, Steve Dickson wrote:
>> nfsctl.c: In function 'expsetup':
>> nfsctl.c:112: warning: signed and unsigned type in conditional expression
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> support/export/nfsctl.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/support/export/nfsctl.c b/support/export/nfsctl.c
>> index 3b9876a..f89c644 100644
>> --- a/support/export/nfsctl.c
>> +++ b/support/export/nfsctl.c
>> @@ -109,7 +109,7 @@ expsetup(struct nfsctl_export *exparg, nfs_export *exp, int unexport)
>> str_tolower(exparg->ex_client);
>> exparg->ex_flags = exp->m_export.e_flags;
>> exparg->ex_dev = (!unexport && (exp->m_export.e_flags & NFSEXP_FSID)) ?
>> - exp->m_export.e_fsid : stb.st_dev;
>> + (__nfsd_dev_t)exp->m_export.e_fsid : stb.st_dev;
>
> Any reason not to just define e_fsid as an __nfsd_dev_t to start off
> with?
Well would changing e_fsid from a int to an unsigned long (i.e. __nfsd_dev_t)
break the dump_to_cache() interface between the mound and the kernel?
steved.
>
> --b.
>
>> exparg->ex_ino = stb.st_ino;
>> exparg->ex_anon_uid = exp->m_export.e_anonuid;
>> exparg->ex_anon_gid = exp->m_export.e_anongid;
>> --
>> 1.7.0.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-04 12:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 23:37 [PATCH 00/24] Turn on the -Wextra compile flag Steve Dickson
2010-07-20 23:37 ` [PATCH 01/24] Enable extra compile warnings (-Wextra) by default Steve Dickson
2010-07-20 23:37 ` [PATCH 02/24] Remove warnings from nfsctl.c Steve Dickson
2010-07-21 17:06 ` J. Bruce Fields
2010-08-04 12:36 ` Steve Dickson [this message]
2010-07-20 23:37 ` [PATCH 03/24] Removed warnings from rpcdispatch.c Steve Dickson
2010-07-20 23:37 ` [PATCH 04/24] Remove warnings from svc_socket.c Steve Dickson
2010-07-20 23:37 ` [PATCH 05/24] emove warnings from cacheio.c Steve Dickson
2010-07-20 23:37 ` [PATCH 06/24] Remove warnings from nfs_mntent.c Steve Dickson
2010-07-20 23:37 ` [PATCH 07/24] Removed warnings from conffile.c Steve Dickson
2010-07-20 23:37 ` [PATCH 08/24] Removed warnings from mountd.c Steve Dickson
2010-07-21 17:12 ` J. Bruce Fields
2010-08-04 13:44 ` Steve Dickson
2010-07-21 17:23 ` Chuck Lever
2010-08-04 13:50 ` Steve Dickson
2010-08-04 15:57 ` Chuck Lever
2010-07-20 23:37 ` [PATCH 09/24] Removed warnings from fsloc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 10/24] Removed warnings from cache.c Steve Dickson
2010-07-20 23:37 ` [PATCH 11/24] Removed warnings from nfssvc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 12/24] Removed warnings from nfsstat.c Steve Dickson
2010-07-20 23:37 ` [PATCH 13/24] Removed warnings from atomicio.c Steve Dickson
2010-07-20 23:37 ` [PATCH 14/24] Removed warnings from idmapd.c Steve Dickson
2010-07-21 17:24 ` J. Bruce Fields
2010-07-20 23:37 ` [PATCH 15/24] Removed warnings from gssd.c Steve Dickson
2010-07-20 23:37 ` [PATCH 16/24] Removed warnings from gssd_main_loop.c Steve Dickson
2010-07-20 23:37 ` [PATCH 17/24] Removed warnings from krb5_util.c Steve Dickson
2010-07-20 23:37 ` [PATCH 18/24] Removed warnings from gssd_proc.c Steve Dickson
2010-07-20 23:37 ` [PATCH 19/24] Removed warnings from svcgssd.c Steve Dickson
2010-07-20 23:37 ` [PATCH 20/24] Removed warnings from svcgssd_proc.c Steve Dickson
2010-07-21 17:23 ` J. Bruce Fields
2010-07-20 23:37 ` [PATCH 21/24] Removed warnings from network.c Steve Dickson
2010-07-21 17:17 ` Chuck Lever
2010-07-20 23:37 ` [PATCH 22/24] Removed warnings from nfsmount.c Steve Dickson
2010-07-20 23:37 ` [PATCH 23/24] Removed warnings from nfs4mount.c Steve Dickson
2010-07-20 23:37 ` [PATCH 24/24] Removed warnings from configfile.c Steve Dickson
2010-07-21 17:53 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C595EC3.2040500@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).