From: Boaz Harrosh <bharrosh@panasas.com>
To: "J. Bruce Fields" <bfields@citi.umich.edu>
Cc: Benny Halevy <bhalevy@panasas.com>,
"Labiaga, Ricardo" <Ricardo.Labiaga@netapp.com>,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH version2] nfsd41: Fix a crash when a callback is retried
Date: Mon, 23 Aug 2010 13:10:28 +0300 [thread overview]
Message-ID: <4C724914.2050206@panasas.com> (raw)
In-Reply-To: <20100805142226.GA27141@fieldses.org>
On 08/05/2010 05:22 PM, J. Bruce Fields wrote:
> Thanks, applied. There may be a delay before it shows up in my
> for-2.6.36 queue, while I sort out a few other bugs.
>
> (We still have problems here: getting a new slot isn't always the
> correct thing to do, depending on the error. But this seems an
> improvement....).
>
We do free the slot unconditionally, (hence the crash) so we better
grab a new one.
Please store in the corner of your mind those cases you think should
not free the slot, I promise to put it on my todo, and come back to it.
We will then have to switch on these case that don't free the slot and
bail out early. At this point of the code, it will remain the same.
But you are right, I have not thought about these cases.
> --b.
Thanks
Boaz
next prev parent reply other threads:[~2010-08-23 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 17:33 [PATCH] nfsd41: Fix a crash when a callback is retried Boaz Harrosh
2010-06-28 17:38 ` Boaz Harrosh
2010-06-28 18:50 ` Benny Halevy
2010-06-29 7:43 ` Boaz Harrosh
2010-06-29 11:33 ` [PATCH version2] " Boaz Harrosh
2010-07-01 18:28 ` Benny Halevy
2010-07-20 14:37 ` Boaz Harrosh
2010-07-21 23:28 ` J. Bruce Fields
2010-08-05 14:22 ` J. Bruce Fields
2010-08-23 10:10 ` Boaz Harrosh [this message]
2010-08-23 22:32 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C724914.2050206@panasas.com \
--to=bharrosh@panasas.com \
--cc=Ricardo.Labiaga@netapp.com \
--cc=bfields@citi.umich.edu \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).