public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Support IPv6 in libexport.a
Date: Tue, 31 Aug 2010 15:43:31 -0400	[thread overview]
Message-ID: <4C7D5B63.9060907@RedHat.com> (raw)
In-Reply-To: <20100824162926.2433.7535.stgit@matisse.1015granger.net>



On 08/24/2010 12:35 PM, Chuck Lever wrote:
> Hi Steve-
> 
> This patch set should encapsulate IPv6-related changes needed in
> support/export/client.c .  It updates logic that parses presentation
> addresses and netmasks, and logic that compares socket addresses.
> 
> ---
> 
> Chuck Lever (5):
>       libexport.a: IPv6 support in client_check()
>       libexport.a: IPv6 support for client_init_subnet()
>       libexport.a: Prepare init_subnetwork() for IPv6 support
>       libexport.a: Use host helper to parse address in client_init()
>       libexport.a: Prepare to recognize IPv6 addresses in client_gettype()
> 
> 
>  support/export/client.c |  208 +++++++++++++++++++++++++++++++++++------------
>  1 files changed, 153 insertions(+), 55 deletions(-)
> 
All 5 Committed... As far as "bending the cardinal rule of not
using "#ifdef" inside functions"... I too did not see a cleaner
way of doing it... so I don't think its a big deal.. but maybe
down the road we can rework things were those ifdef are not
needed... but only time will tell...

steved.

  parent reply	other threads:[~2010-08-31 19:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 16:35 [PATCH 0/5] Support IPv6 in libexport.a Chuck Lever
2010-08-24 16:35 ` [PATCH 1/5] libexport.a: Prepare to recognize IPv6 addresses in client_gettype() Chuck Lever
2010-08-24 16:35 ` [PATCH 2/5] libexport.a: Use host helper to parse address in client_init() Chuck Lever
2010-08-24 16:35 ` [PATCH 3/5] libexport.a: Prepare init_subnetwork() for IPv6 support Chuck Lever
2010-08-24 16:35 ` [PATCH 4/5] libexport.a: IPv6 support for client_init_subnet() Chuck Lever
2010-08-24 16:36 ` [PATCH 5/5] libexport.a: IPv6 support in client_check() Chuck Lever
2010-08-31 19:43 ` Steve Dickson [this message]
     [not found]   ` <4C7D5B63.9060907-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-08-31 20:36     ` [PATCH 0/5] Support IPv6 in libexport.a Chuck Lever
2010-08-31 23:41       ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7D5B63.9060907@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox