From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] mount: RDMA processing in the mount command is broken
Date: Thu, 02 Sep 2010 18:04:23 -0400 [thread overview]
Message-ID: <4C801F67.50604@RedHat.com> (raw)
In-Reply-To: <E401A220-AAD8-42F1-AE81-3B1EEF209428@oracle.com>
On 09/02/2010 04:35 PM, Chuck Lever wrote:
>
> On Sep 2, 2010, at 4:00 PM, Steve Dickson wrote:
>
>> The mounting code that process RMDA mounts is broken in a few places
>>
>> First with '-o proto=rdma' was broken because nfs_get_proto()
>> did not how to convert a netid of 'rdma' in to a AF_INET
>> address family.
>>
>> Secondly, '-o rdma' was broken because po_get() was being using
>> to detect the existence of 'rdma' in the options. With '-o rdma'
>> there is no value associated with that option so po_get()
>> was always return NULL.
>
> Looking at nfs(5), "rdma" as a stand-alone option isn't documented. Only "proto=rdma" appears to be mentioned. Thus I would argue that this is already behaving correctly.
>
> Are you proposing to add support for "-o rdma" ? If so what would that mean?
See Documentation/filesystems/nfs/nfs-rdma.txt
I see no problem in handing this same why we handle 'udp' and 'tcp'
steved.
next prev parent reply other threads:[~2010-09-02 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 20:00 [PATCH 1/1] mount: RDMA processing in the mount command is broken Steve Dickson
2010-09-02 20:15 ` Chuck Lever
2010-09-02 22:45 ` Steve Dickson
2010-09-03 16:01 ` Chuck Lever
2010-09-03 19:59 ` Steve Dickson
2010-09-07 15:51 ` Chuck Lever
2010-09-02 20:35 ` Chuck Lever
2010-09-02 22:04 ` Steve Dickson [this message]
2010-09-03 15:01 ` Chuck Lever
2010-09-03 19:53 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C801F67.50604@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox