From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] libexport.a: Refactor init_netmask()
Date: Thu, 09 Sep 2010 13:52:17 -0400 [thread overview]
Message-ID: <4C891ED1.1080204@RedHat.com> (raw)
In-Reply-To: <AC20E599-9576-4F97-97BD-8E9B2E3E3F87@oracle.com>
On 09/09/2010 01:03 PM, Chuck Lever wrote:
> Hi Steve-
>
> On Sep 9, 2010, at 10:38 AM, Steve Dickson wrote:
>
>>
>> On 09/02/2010 03:23 PM, Chuck Lever wrote:
>>> Instead of a single function that can handle both AF_INET and AF_INET6
>>> addresses, two separate functions might be cleaner.
>>>
>>> The original plan was to keep code redundancy at a minimum, but the
>>> resulting code was cumbersome at best. I think I've traded a little
>>> extra code for something that will be much easier to read, understand,
>>> and maintain.
>>>
>>> I've also eliminated the "#if / #endif" instances inside the functions.
>>>
>>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>>> ---
>> Committed...
>
> This (and the RDMA patches) appears in nfs-utils-exp.git, but not in nfs-utils.git.
>
> For my development tree, I pull from the latter.
> Should I pull from nfs-utils-exp instead?
Sorry about that, the patches now on the correct tree..
steved.
>
prev parent reply other threads:[~2010-09-09 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 19:23 [PATCH] libexport.a: Refactor init_netmask() Chuck Lever
[not found] ` <20100902192350.1755.66184.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2010-09-09 14:38 ` Steve Dickson
[not found] ` <4C88F16B.10802-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-09-09 17:03 ` Chuck Lever
2010-09-09 17:52 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C891ED1.1080204@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox