Re: [PATCH 08/13] RFC: pnfs: filelayout: introduce minimal file layout driver

Christoph Hellwig
2010-09-13T15:08:44Z

On Thu, Sep 02, 2010 at 02:00:14PM -0400, Fred Isaman wrote:
> +static int __init nfs4filelayout_init(void)
> +{
> + printk(KERN_INFO "%s: NFSv4 File Layout Driver Registering...\n",
> + __func__);
> +
> + /*
> + * Need to register file_operations struct with global list to indicate
> + * that NFS4 file layout is a possible pNFS I/O module
> + */
> + return pnfs_register_layoutdriver(&filelayout_type);

And I thought we were dealing with an UFO detection device here..

Sarcasm aside, this is one of the most pointless and incorrect comments I've
seen for a while.

> + /* Unregister NFS4 file layout driver with pNFS client*/
> + pnfs_unregister_layoutdriver(&filelayout_type);

This one is not too useful either.