Re: [PATCH 08/13] RFC: pnfs: filelayout: introduce minimal file layout driver

Benny Halevy
2010-09-13T11:28:56Z

On 2010-09-11 03:13, Trond Myklebust wrote:
> On Fri, 2010-09-10 at 20:07 -0400, Christoph Hellwig wrote:
>> On Fri, Sep 10, 2010 at 08:03:53PM -0400, Trond Myklebust wrote:
>>> So you are saying we should simply equate CONFIG_PNFS_FILE_LAYOUT and
>>> CONFIG_NFS_V4_1 right now? Yep, I'd be fine with that... I'm still
>>> working on the patches to get rid of all these CONFIG options, but
>>> ultimately this is what I'm working towards.
>>
>> If you don't want a separate option that's up to you, but I don't think
>> forcing people to built the pnfs file layout just because they want nfs4.1
>> features is an all that smart idea.
>
> IMHO it should be fine.
>
> Most people will be compiling NFS as a module, in which case, the pnfs
> file layout is just another module that can be left out from the final
> binary if people don't want it.
>
> I'm still waiting to hear from people who want to compile NFSv4.1 in the
> main kernel, but who want pNFS to be modularised.

If a user uses a different layout driver and not the files layout driver
than the latter is just extra baggage. That said, the way Fred implemented
the Kconfig option, it cannot be disabled independently anyway so it's rather
pointless.

Benny

>
> Cheers
> Trond
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html