From: Benny Halevy <bhalevy@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: Jim Rees <rees@umich.edu>,
linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: another block layout oops
Date: Fri, 01 Oct 2010 09:58:45 +0200 [thread overview]
Message-ID: <4CA594B5.1090207@panasas.com> (raw)
In-Reply-To: <AANLkTi=bRwN3uoszG0jTzVSPMSwP6VKn+rW470uWwAj1@mail.gmail.com>
On 2010-10-01 04:14, Fred Isaman wrote:
> On Thu, Sep 30, 2010 at 5:52 PM, Jim Rees <rees@umich.edu> wrote:
>> Benny Halevy wrote:
>>
>> Jim, would you mind retesting with pnfs-all-2.6.36-rc6-2010-09-30?
>> Not that there's any possible fix there, but a fresh Oops could
>> help, if you can reproduce it.
>>
>> Will do, probably after an important meeting I have at 6:00 this evening.
>
> There is a problem with the LAYOUTGET error handling, which is
> probably what Jim is hitting (the block servers are much more likely
> to send RETRYLATER). I'll send in a fix tomorrow morning.
One problem I can see is that nfs4_layoutget_release frees calldata
(a.k.a. lgp) which is reused later if we retry.
We should either keep a reference count on it or clone it internally
in _nfs4_proc_layoutget for each call. Since the calls are essentially
synchronous the caller and allocator (e.g. send_layoutget) can just
free the call data (or dereference, if we keep a refcount).
Same for layoutcommit and layoutreturn.
Benny
>
> Fred
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
next prev parent reply other threads:[~2010-10-01 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 17:13 another block layout oops Jim Rees
2010-09-30 21:40 ` Benny Halevy
2010-09-30 21:52 ` Jim Rees
2010-10-01 2:14 ` Fred Isaman
2010-10-01 7:58 ` Benny Halevy [this message]
2010-10-01 16:45 ` Fred Isaman
2010-10-01 17:06 ` Jim Rees
2010-10-01 17:11 ` Fred Isaman
[not found] ` <AANLkTi=T6PY6MDzbyWikSYOi7HoMWAsEarw-3k=S1+Bu-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-01 17:56 ` Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA594B5.1090207@panasas.com \
--to=bhalevy@panasas.com \
--cc=honey@citi.umich.edu \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).