From: Benjamin Coddington <bcodding@redhat.com>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Frank van der Linden <fllinden@amazon.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] NFSv4.2: fix error handling in nfs42_proc_getxattr
Date: Wed, 26 Jul 2023 11:04:24 -0400 [thread overview]
Message-ID: <4CA714BC-E458-4F90-B6D4-C61B5A8D61CF@redhat.com> (raw)
In-Reply-To: <20230725115900.23690-1-pchelkin@ispras.ru>
On 25 Jul 2023, at 7:58, Fedor Pchelkin wrote:
> There is a slight issue with error handling code inside
> nfs42_proc_getxattr(). If page allocating loop fails then we free the
> failing page array element which is NULL but __free_page() can't deal with
> NULL args.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: a1f26739ccdc ("NFSv4.2: improve page handling for GETXATTR")
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Looks right to me,
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Ben
prev parent reply other threads:[~2023-07-26 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:58 [PATCH] NFSv4.2: fix error handling in nfs42_proc_getxattr Fedor Pchelkin
2023-07-26 15:04 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA714BC-E458-4F90-B6D4-C61B5A8D61CF@redhat.com \
--to=bcodding@redhat.com \
--cc=anna@kernel.org \
--cc=fllinden@amazon.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pchelkin@ispras.ru \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).