From: Benny Halevy <bhalevy@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] Don't check exchange flags unless using v4.1
Date: Wed, 06 Oct 2010 12:02:11 -0400 [thread overview]
Message-ID: <4CAC9D83.2090406@panasas.com> (raw)
In-Reply-To: <1286380572-4558-1-git-send-email-iisaman@netapp.com>
On 2010-10-06 11:56, Fred Isaman wrote:
> Signed-off-by: Fred Isaman <iisaman@netapp.com>
> ---
> fs/nfs/pnfs.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index 7013916..64baf20 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -141,7 +141,9 @@ set_pnfs_layoutdriver(struct nfs_server *server, u32 id)
>
> if (id == 0)
> goto out_no_driver;
> - if (!(server->nfs_client->cl_exchange_flags &
> + if ((server->nfs_client->rpc_ops->version == 4) &&
> + (server->nfs_client->cl_minorversion == 1) &&
> + !(server->nfs_client->cl_exchange_flags &
> (EXCHGID4_FLAG_USE_NON_PNFS | EXCHGID4_FLAG_USE_PNFS_MDS))) {
> printk(KERN_ERR "%s: id %u cl_exchange_flags 0x%x\n", __func__,
> id, server->nfs_client->cl_exchange_flags);
Actually, it'd better to disable just the warning printout in this case,
not the entire block.
Benny
next prev parent reply other threads:[~2010-10-06 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 15:56 [PATCH 1/1] Don't check exchange flags unless using v4.1 Fred Isaman
2010-10-06 16:02 ` Benny Halevy [this message]
2010-10-06 16:10 ` Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAC9D83.2090406@panasas.com \
--to=bhalevy@panasas.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox