* [PATCH] nfs: fix unchecked value
@ 2010-10-13 12:54 Roman Borisov
2010-10-19 14:16 ` Roman Borisov
0 siblings, 1 reply; 2+ messages in thread
From: Roman Borisov @ 2010-10-13 12:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Trond.Myklebust, linux-nfs, Roman Borisov
Return value of "decode_attr_bitmap()" was not checked;
Signed-off-by: Roman Borisov <ext-roman.borisov@nokia.com>
---
fs/nfs/nfs4xdr.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index 6ea5c93..9e9cb40 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -2676,7 +2676,10 @@ out_overflow:
static int decode_attr_supported(struct xdr_stream *xdr, uint32_t *bitmap, uint32_t *bitmask)
{
if (likely(bitmap[0] & FATTR4_WORD0_SUPPORTED_ATTRS)) {
- decode_attr_bitmap(xdr, bitmask);
+ int ret;
+ ret = decode_attr_bitmap(xdr, bitmask);
+ if (unlikely(ret < 0))
+ return ret;
bitmap[0] &= ~FATTR4_WORD0_SUPPORTED_ATTRS;
} else
bitmask[0] = bitmask[1] = 0;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nfs: fix unchecked value
2010-10-13 12:54 [PATCH] nfs: fix unchecked value Roman Borisov
@ 2010-10-19 14:16 ` Roman Borisov
0 siblings, 0 replies; 2+ messages in thread
From: Roman Borisov @ 2010-10-19 14:16 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Shevchenko, Trond.Myklebust, linux-nfs
On 10/13/2010 04:54 PM, Roman Borisov wrote:
> Return value of "decode_attr_bitmap()" was not checked;
>
> Signed-off-by: Roman Borisov<ext-roman.borisov@nokia.com>
> ---
> fs/nfs/nfs4xdr.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 6ea5c93..9e9cb40 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -2676,7 +2676,10 @@ out_overflow:
> static int decode_attr_supported(struct xdr_stream *xdr, uint32_t *bitmap, uint32_t *bitmask)
> {
> if (likely(bitmap[0]& FATTR4_WORD0_SUPPORTED_ATTRS)) {
> - decode_attr_bitmap(xdr, bitmask);
> + int ret;
> + ret = decode_attr_bitmap(xdr, bitmask);
> + if (unlikely(ret< 0))
> + return ret;
> bitmap[0]&= ~FATTR4_WORD0_SUPPORTED_ATTRS;
> } else
> bitmask[0] = bitmask[1] = 0;
Reviewed-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Hello,
could you please review the patch and send the comments if any
Thanks,
Roman Borisov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-19 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 12:54 [PATCH] nfs: fix unchecked value Roman Borisov
2010-10-19 14:16 ` Roman Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).