From: Boaz Harrosh <bharrosh@panasas.com>
To: Jim Rees <rees@umich.edu>
Cc: Benny Halevy <bhalevy@panasas.com>,
linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH] move include lines out of include file
Date: Sun, 24 Oct 2010 14:02:04 +0200 [thread overview]
Message-ID: <4CC4203C.2050600@panasas.com> (raw)
In-Reply-To: <20101022005120.GA15788@merit.edu>
On 10/22/2010 02:51 AM, Jim Rees wrote:
> Signed-off-by: Jim Rees <rees@umich.edu>
> ---
> include/linux/sunrpc/simple_rpc_pipefs.h | 6 ------
> net/sunrpc/simple_rpc_pipefs.c | 5 +++++
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/sunrpc/simple_rpc_pipefs.h b/include/linux/sunrpc/simple_rpc_pipefs.h
> index 02e8147..f6a1227 100644
> --- a/include/linux/sunrpc/simple_rpc_pipefs.h
> +++ b/include/linux/sunrpc/simple_rpc_pipefs.h
> @@ -39,14 +39,8 @@
> #ifndef _SIMPLE_RPC_PIPEFS_H_
> #define _SIMPLE_RPC_PIPEFS_H_
>
> -#include <linux/fs.h>
> -#include <linux/list.h>
> -#include <linux/mount.h>
> -#include <linux/sched.h>
> -#include <linux/sunrpc/clnt.h>
> #include <linux/sunrpc/rpc_pipe_fs.h>
>
> -
> #define payload_of(headerp) ((void *)(headerp + 1))
>
> /*
> diff --git a/net/sunrpc/simple_rpc_pipefs.c b/net/sunrpc/simple_rpc_pipefs.c
> index c9306aa..b749cf7 100644
> --- a/net/sunrpc/simple_rpc_pipefs.c
> +++ b/net/sunrpc/simple_rpc_pipefs.c
> @@ -41,6 +41,11 @@
> #include <linux/completion.h>
> #include <linux/uaccess.h>
> #include <linux/module.h>
> +#include <linux/fs.h>
> +#include <linux/list.h>
> +#include <linux/mount.h>
> +#include <linux/sched.h>
> +#include <linux/sunrpc/clnt.h>
> #include <linux/sunrpc/simple_rpc_pipefs.h>
>
This patch does *not* break the header's independence. .i.e
the header can still be compiled independently without any other
includes. Which means some of the includes here are un-needed.
See patch below. (Please squash it into your patch)
Boaz
---
git diff --stat -p -M net/sunrpc/simple_rpc_pipefs.c
net/sunrpc/simple_rpc_pipefs.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/net/sunrpc/simple_rpc_pipefs.c b/net/sunrpc/simple_rpc_pipefs.c
index c4825b7..24e2277 100644
--- a/net/sunrpc/simple_rpc_pipefs.c
+++ b/net/sunrpc/simple_rpc_pipefs.c
@@ -38,13 +38,7 @@
* With thanks to CITI's project sponsor and partner, IBM.
*/
-#include <linux/completion.h>
-#include <linux/uaccess.h>
-#include <linux/module.h>
-#include <linux/fs.h>
-#include <linux/list.h>
#include <linux/mount.h>
-#include <linux/sched.h>
#include <linux/sunrpc/clnt.h>
#include <linux/sunrpc/simple_rpc_pipefs.h>
next prev parent reply other threads:[~2010-10-24 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 0:51 [PATCH] move include lines out of include file Jim Rees
2010-10-24 12:02 ` Boaz Harrosh [this message]
2010-10-24 15:35 ` Jim Rees
2010-10-25 11:41 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC4203C.2050600@panasas.com \
--to=bharrosh@panasas.com \
--cc=bhalevy@panasas.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).