From: Benny Halevy <bhalevy@panasas.com>
To: Jim Rees <rees@umich.edu>, Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH] move include lines out of include file
Date: Mon, 25 Oct 2010 13:41:02 +0200 [thread overview]
Message-ID: <4CC56CCE.2050503@panasas.com> (raw)
In-Reply-To: <20101024153503.GC10769@merit.edu>
On 2010-10-24 17:35, Jim Rees wrote:
> Boaz Harrosh wrote:
>
> This patch does *not* break the header's independence. .i.e the header can
> still be compiled independently without any other includes. Which means
> some of the includes here are un-needed.
>
> Thanks! I tried removing all the includes but was too lazy to figure out
> which one was really needed by simple_rpc_pipefs.c.
Yup.
The self-sustainability approach is the best one, i.e. header files
should include the minimum number of other header files to satisfy their
dependencies.
I'll merge both patches squashed together then.
Benny
prev parent reply other threads:[~2010-10-25 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 0:51 [PATCH] move include lines out of include file Jim Rees
2010-10-24 12:02 ` Boaz Harrosh
2010-10-24 15:35 ` Jim Rees
2010-10-25 11:41 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC56CCE.2050503@panasas.com \
--to=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).