* Re: [PATCH] nfs-utils: fix default value for --enable-tirpc
2010-10-12 1:29 [PATCH] nfs-utils: fix default value for --enable-tirpc Jeff Layton
@ 2010-10-12 17:44 ` J. Bruce Fields
2010-10-28 13:24 ` Steve Dickson
2010-11-01 12:11 ` Steve Dickson
2 siblings, 0 replies; 6+ messages in thread
From: J. Bruce Fields @ 2010-10-12 17:44 UTC (permalink / raw)
To: Jeff Layton; +Cc: steved, chuck.lever, linux-nfs
On Mon, Oct 11, 2010 at 09:29:51PM -0400, Jeff Layton wrote:
> The patch I originally proposed to make --enable-tirpc the default had
> the default for $enable_tirpc as a blank string. When it was merged
> however, that value was changed to a 'yes'. This broke the ability for
> autoconf to detect and autodisable building with tirpc. When tirpc isn't
> present now, the configure step fails unless someone explicitly
> specifies --disable-libtirpc.
>
> We need $enable_tirpc to be a tristate. 'yes' means that someone
> explicitly requested building with tirpc. 'no' means that it was
> explicitly disabled. Anything else means that no one specified a value.
>
> Fix it by setting the value to a blank string so that the default is
> properly undefined.
Thanks for looking into that, it's FAQ #1 for people rolling their own
these days....
--b.
>
> Reported-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3058be6..5408e85 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
> [AC_HELP_STRING([--enable-tirpc],
> [enable use of TI-RPC @<:@default=yes@:>@])],
> enable_tirpc=$enableval,
> - enable_tirpc='yes')
> + enable_tirpc='')
> AC_ARG_ENABLE(ipv6,
> [AC_HELP_STRING([--enable-ipv6],
> [enable support for IPv6 @<:@default=no@:>@])],
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs-utils: fix default value for --enable-tirpc
2010-10-12 1:29 [PATCH] nfs-utils: fix default value for --enable-tirpc Jeff Layton
2010-10-12 17:44 ` J. Bruce Fields
@ 2010-10-28 13:24 ` Steve Dickson
2010-10-28 13:38 ` Jeff Layton
2010-11-01 12:11 ` Steve Dickson
2 siblings, 1 reply; 6+ messages in thread
From: Steve Dickson @ 2010-10-28 13:24 UTC (permalink / raw)
To: Jeff Layton; +Cc: chuck.lever, linux-nfs
Jeff,
On 10/11/2010 09:29 PM, Jeff Layton wrote:
> The patch I originally proposed to make --enable-tirpc the default had
> the default for $enable_tirpc as a blank string. When it was merged
> however, that value was changed to a 'yes'.
Which commit or proposal are you talking about? I'm looking at commit 148503a
which changed it for no to yes, but I can not seem to find the
proposal you are talking about?
I'm just trying to figure how the merge broke it so it does
not happen again...
steved.
> This broke the ability for
> autoconf to detect and autodisable building with tirpc. When tirpc isn't
> present now, the configure step fails unless someone explicitly
> specifies --disable-libtirpc.
>
> We need $enable_tirpc to be a tristate. 'yes' means that someone
> explicitly requested building with tirpc. 'no' means that it was
> explicitly disabled. Anything else means that no one specified a value.
>
> Fix it by setting the value to a blank string so that the default is
> properly undefined.
>
> Reported-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3058be6..5408e85 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
> [AC_HELP_STRING([--enable-tirpc],
> [enable use of TI-RPC @<:@default=yes@:>@])],
> enable_tirpc=$enableval,
> - enable_tirpc='yes')
> + enable_tirpc='')
> AC_ARG_ENABLE(ipv6,
> [AC_HELP_STRING([--enable-ipv6],
> [enable support for IPv6 @<:@default=no@:>@])],
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs-utils: fix default value for --enable-tirpc
2010-10-28 13:24 ` Steve Dickson
@ 2010-10-28 13:38 ` Jeff Layton
2010-10-28 14:03 ` Steve Dickson
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2010-10-28 13:38 UTC (permalink / raw)
To: Steve Dickson; +Cc: chuck.lever, linux-nfs
On Thu, 28 Oct 2010 09:24:00 -0400
Steve Dickson <SteveD@redhat.com> wrote:
> Jeff,
>
> On 10/11/2010 09:29 PM, Jeff Layton wrote:
> > The patch I originally proposed to make --enable-tirpc the default had
> > the default for $enable_tirpc as a blank string. When it was merged
> > however, that value was changed to a 'yes'.
> Which commit or proposal are you talking about? I'm looking at commit 148503a
> which changed it for no to yes, but I can not seem to find the
> proposal you are talking about?
>
> I'm just trying to figure how the merge broke it so it does
> not happen again...
>
> steved.
>
Here was the original patch posting:
http://www.spinics.net/lists/linux-nfs/msg07718.html
I checked my mail archives and didn't see emails where we discussed
this patch specifically around that time. Maybe we did on IRC before
you merged it and I misunderstood what you intended to change? Hard to
remember since it was over a year ago...
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs-utils: fix default value for --enable-tirpc
2010-10-28 13:38 ` Jeff Layton
@ 2010-10-28 14:03 ` Steve Dickson
0 siblings, 0 replies; 6+ messages in thread
From: Steve Dickson @ 2010-10-28 14:03 UTC (permalink / raw)
To: Jeff Layton; +Cc: chuck.lever, linux-nfs
On 10/28/2010 09:38 AM, Jeff Layton wrote:
> On Thu, 28 Oct 2010 09:24:00 -0400
> Steve Dickson <SteveD@redhat.com> wrote:
>
>> Jeff,
>>
>> On 10/11/2010 09:29 PM, Jeff Layton wrote:
>>> The patch I originally proposed to make --enable-tirpc the default had
>>> the default for $enable_tirpc as a blank string. When it was merged
>>> however, that value was changed to a 'yes'.
>> Which commit or proposal are you talking about? I'm looking at commit 148503a
>> which changed it for no to yes, but I can not seem to find the
>> proposal you are talking about?
>>
>> I'm just trying to figure how the merge broke it so it does
>> not happen again...
>>
>> steved.
>>
>
> Here was the original patch posting:
>
> http://www.spinics.net/lists/linux-nfs/msg07718.html
>
> I checked my mail archives and didn't see emails where we discussed
> this patch specifically around that time. Maybe we did on IRC before
> you merged it and I misunderstood what you intended to change? Hard to
> remember since it was over a year ago...
I generally just cut and paste the patches and if
I make any changes I post them... So I'm wondering
how that got changed... anyway... its fixed now...
steved.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs-utils: fix default value for --enable-tirpc
2010-10-12 1:29 [PATCH] nfs-utils: fix default value for --enable-tirpc Jeff Layton
2010-10-12 17:44 ` J. Bruce Fields
2010-10-28 13:24 ` Steve Dickson
@ 2010-11-01 12:11 ` Steve Dickson
2 siblings, 0 replies; 6+ messages in thread
From: Steve Dickson @ 2010-11-01 12:11 UTC (permalink / raw)
To: Jeff Layton; +Cc: chuck.lever, linux-nfs
On 10/11/2010 09:29 PM, Jeff Layton wrote:
> The patch I originally proposed to make --enable-tirpc the default had
> the default for $enable_tirpc as a blank string. When it was merged
> however, that value was changed to a 'yes'. This broke the ability for
> autoconf to detect and autodisable building with tirpc. When tirpc isn't
> present now, the configure step fails unless someone explicitly
> specifies --disable-libtirpc.
>
> We need $enable_tirpc to be a tristate. 'yes' means that someone
> explicitly requested building with tirpc. 'no' means that it was
> explicitly disabled. Anything else means that no one specified a value.
>
> Fix it by setting the value to a blank string so that the default is
> properly undefined.
>
> Reported-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3058be6..5408e85 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
> [AC_HELP_STRING([--enable-tirpc],
> [enable use of TI-RPC @<:@default=yes@:>@])],
> enable_tirpc=$enableval,
> - enable_tirpc='yes')
> + enable_tirpc='')
> AC_ARG_ENABLE(ipv6,
> [AC_HELP_STRING([--enable-ipv6],
> [enable support for IPv6 @<:@default=no@:>@])],
Committed...
steved.
^ permalink raw reply [flat|nested] 6+ messages in thread