From: Steve Dickson <SteveD@redhat.com>
To: Jim Rees <rees@umich.edu>
Cc: Harshula Jayasuriya <harshula@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: nfsstat: has_stats() does not function correctly for NFSv4 client stats
Date: Wed, 10 Nov 2010 13:03:49 -0500 [thread overview]
Message-ID: <4CDADE85.6030806@RedHat.com> (raw)
In-Reply-To: <20101110162703.GA948@merit.edu>
On 11/10/2010 11:27 AM, Jim Rees wrote:
> Harshula Jayasuriya wrote:
>
> On Tue, 2010-11-09 at 14:29 -0500, Chuck Lever wrote:
> > Hi-
> >
> > Why not use mountstats? The /proc/net/rpc/nfs is destined for deprecation, I thought.
>
> Are you referring to /proc/self/mountstats? I didn't know about it.
> nfsstat's get_stats() would have to be re-written. I can add that to my
> TODO list, but not sure when I'll get to it. In the meantime, this patch
> will fix the previously mentioned bugs and make the existing code a
> little clearer.
>
> We should either fix it or remove it. Leaving it in and broken seems wrong
> even if the interface is depracated, especially since we have a fix.
Of course... I was not clear... I'll take the patch to fix the bug
but I don't think its worth whiled to teach nfsstat how read
stats from /proc/self/mountstats... I would rather put the effort into
improving both the nfsiostat and mountstats command.
steved.
next prev parent reply other threads:[~2010-11-10 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 18:50 [PATCH] nfs-utils: nfsstat: has_stats() does not function correctly for NFSv4 client stats Harshula Jayasuriya
2010-11-09 19:29 ` Chuck Lever
2010-11-10 4:26 ` Harshula Jayasuriya
2010-11-10 15:08 ` Steve Dickson
2010-11-10 16:27 ` Jim Rees
2010-11-10 18:03 ` Steve Dickson [this message]
2010-11-22 17:16 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDADE85.6030806@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=harshula@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).