From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:49369 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402Ab0KVRbb (ORCPT ); Mon, 22 Nov 2010 12:31:31 -0500 Message-ID: <4CEAA8EE.4090301@RedHat.com> Date: Mon, 22 Nov 2010 12:31:26 -0500 From: Steve Dickson To: Mi Jinlong CC: NFSv3 list Subject: Re: [PATCH] libnfs.a: fix a bug when parse section's arg References: <4CD36FE7.1010100@cn.fujitsu.com> <4CD8A5CF.4050007@cn.fujitsu.com> In-Reply-To: <4CD8A5CF.4050007@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 11/08/2010 08:37 PM, Mi Jinlong wrote: > When parsing section's arg at configure file, the pointer > should stop when fetch ']', and give the warning message. > > Signed-off-by: Mi Jinlong > --- > support/nfs/conffile.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/support/nfs/conffile.c b/support/nfs/conffile.c > index 24640f4..798e5f3 100644 > --- a/support/nfs/conffile.c > +++ b/support/nfs/conffile.c > @@ -271,9 +271,9 @@ conf_parse_line(int trans, char *line, size_t sz) > if (ptr == NULL) > return; > line = ++ptr; > - while (*ptr && *ptr != '"') > + while (*ptr && *ptr != '"' && *ptr != ']') > ptr++; > - if (*ptr == '\0') { > + if (*ptr == '\0' || *ptr == ']') { > xlog_warn("config file error: line %d: " > "non-matched '\"', ignoring until next section", ln); > } else { I'm not seeing how this helps... I realize that with this patch we are saving the processing of a character or two... but what problem is this patch solving? steved.