* [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges()
@ 2010-12-24 5:12 Mi Jinlong
2010-12-24 5:14 ` Mi Jinlong
2011-01-04 16:19 ` Steve Dickson
0 siblings, 2 replies; 3+ messages in thread
From: Mi Jinlong @ 2010-12-24 5:12 UTC (permalink / raw)
To: Steve Dickson; +Cc: NFSv3 list
At nsm_drop_privileges(), for improving readability, unify
the return value.
---
support/nsm/file.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/support/nsm/file.c b/support/nsm/file.c
index e21c7d4..98b47bf 100644
--- a/support/nsm/file.c
+++ b/support/nsm/file.c
@@ -421,7 +421,7 @@ nsm_drop_privileges(const int pidfd)
*/
if (prctl(PR_SET_KEEPCAPS, 1, 0, 0, 0) == -1) {
xlog(L_ERROR, "prctl(PR_SET_KEEPCAPS) failed: %m");
- return 0;
+ return false;
}
if (setgroups(0, NULL) == -1) {
--
1.7.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges()
2010-12-24 5:12 [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges() Mi Jinlong
@ 2010-12-24 5:14 ` Mi Jinlong
2011-01-04 16:19 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Mi Jinlong @ 2010-12-24 5:14 UTC (permalink / raw)
To: Steve Dickson; +Cc: NFSv3 list
At nsm_drop_privileges(), for improving readability, unify
the return value.
Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
---
support/nsm/file.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/support/nsm/file.c b/support/nsm/file.c
index e21c7d4..98b47bf 100644
--- a/support/nsm/file.c
+++ b/support/nsm/file.c
@@ -421,7 +421,7 @@ nsm_drop_privileges(const int pidfd)
*/
if (prctl(PR_SET_KEEPCAPS, 1, 0, 0, 0) == -1) {
xlog(L_ERROR, "prctl(PR_SET_KEEPCAPS) failed: %m");
- return 0;
+ return false;
}
if (setgroups(0, NULL) == -1) {
-- 1.7.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges()
2010-12-24 5:12 [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges() Mi Jinlong
2010-12-24 5:14 ` Mi Jinlong
@ 2011-01-04 16:19 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2011-01-04 16:19 UTC (permalink / raw)
To: Mi Jinlong; +Cc: NFSv3 list
On 12/24/2010 12:12 AM, Mi Jinlong wrote:
> At nsm_drop_privileges(), for improving readability, unify
> the return value.
>
> ---
> support/nsm/file.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/support/nsm/file.c b/support/nsm/file.c
> index e21c7d4..98b47bf 100644
> --- a/support/nsm/file.c
> +++ b/support/nsm/file.c
> @@ -421,7 +421,7 @@ nsm_drop_privileges(const int pidfd)
> */
> if (prctl(PR_SET_KEEPCAPS, 1, 0, 0, 0) == -1) {
> xlog(L_ERROR, "prctl(PR_SET_KEEPCAPS) failed: %m");
> - return 0;
> + return false;
> }
>
> if (setgroups(0, NULL) == -1) {
Committed... Thanks!
steved
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-04 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-24 5:12 [PATCH] libnsm.a: modify return value to false from 0 at nsm_drop_privileges() Mi Jinlong
2010-12-24 5:14 ` Mi Jinlong
2011-01-04 16:19 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).