linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Fixed segfault in rpc.mountd
Date: Wed, 26 Jan 2011 11:34:15 -0500	[thread overview]
Message-ID: <4D404D07.9040200@RedHat.com> (raw)
In-Reply-To: <C6DF5374-6E97-459B-BED1-B044B456AAFE@oracle.com>



On 01/26/2011 10:35 AM, Chuck Lever wrote:
> 
> On Jan 26, 2011, at 7:57 AM, Steve Dickson wrote:
> 
>> A unallocated piece of memory, instead of a NULL point, was being
>> used to initialize a ->next point in the mount link list which
>> caused a segfault after a few remote accesses via the showmount
>> command.
> 
> I thought there was a patch on the list just like this last week... in any event:
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Thanks! 

steved.
> 
> 
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> utils/mountd/rmtab.c |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
>> index d339296..527377f 100644
>> --- a/utils/mountd/rmtab.c
>> +++ b/utils/mountd/rmtab.c
>> @@ -205,6 +205,7 @@ mountlist_list(void)
>> 	}
>> 	if (stb.st_mtime != last_mtime) {
>> 		mountlist_freeall(mlist);
>> +		mlist = NULL;
>> 		last_mtime = stb.st_mtime;
>>
>> 		setrmtabent("r");
> 

  reply	other threads:[~2011-01-26 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 12:57 [PATCH] Fixed segfault in rpc.mountd Steve Dickson
2011-01-26 15:35 ` Chuck Lever
2011-01-26 16:34   ` Steve Dickson [this message]
2011-01-26 16:34 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D404D07.9040200@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).