linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: andros@netapp.com
Cc: iisaman@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/4] NFSv4.1 reclaim complete must wait for completion
Date: Sun, 27 Feb 2011 14:44:49 +0200	[thread overview]
Message-ID: <4D6A4741.3080706@panasas.com> (raw)
In-Reply-To: <1298542269-2477-3-git-send-email-andros@netapp.com>

On 2011-02-24 02:11, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> Reported-by: Trond Myklebust <trond.myklebust@netapp.com>
> ---
>  fs/nfs/nfs4proc.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7d80e78..388817b 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5385,6 +5385,9 @@ static int nfs41_proc_reclaim_complete(struct nfs_client *clp)
>  		status = PTR_ERR(task);
>  		goto out;
>  	}
> +        status = nfs4_wait_for_completion_rpc_task(task);
> +        if (status == 0)
> +                status = task->tk_status;

nit: please use tabs rather than spaces to indent.

Benny

>  	rpc_put_task(task);
>  	return 0;
>  out:

  reply	other threads:[~2011-02-27 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 10:11 [PATCH 1/4] NFS remove duplicate clientid in nfs_client andros
2011-02-24 10:11 ` [PATCH 2/4] SQUASHME: NFSv4.1: DS only check andros
2011-02-25 18:03   ` Fred Isaman
2011-02-27 12:45   ` Benny Halevy
2011-02-24 10:11 ` [PATCH 3/4] NFSv4.1 reclaim complete must wait for completion andros
2011-02-27 12:44   ` Benny Halevy [this message]
2011-02-24 10:11 ` [PATCH 4/4] SQUASHME put_lseg before setting pointer to NULL andros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6A4741.3080706@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=andros@netapp.com \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).