From: Boaz Harrosh <bharrosh@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
NFS list <linux-nfs@vger.kernel.org>,
Andy Adamson <andros@netapp.com>
Subject: Re: [PATCH] SQUASHME: pnfs: FIX stupid recall_layout BUG
Date: Mon, 28 Feb 2011 20:24:37 +0200 [thread overview]
Message-ID: <4D6BE865.7010307@panasas.com> (raw)
In-Reply-To: <AANLkTimZS=54ZkwXwK9tMUUBn_JDXD5=+ohBpnKemtbQ@mail.gmail.com>
On 02/28/2011 12:09 AM, Fred Isaman wrote:
> On Sun, Feb 27, 2011 at 7:04 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> OK, who wrote this code? He did not stop to think for even a
>> second. And surely it was never tested, since it is 100%
>> repeatable. Smack yourself on the head!
>>
>
> I wrote the code. But note that the tree you are using is taking the
> tested, reasonably mature code that is currently in the downstream
> kernel and reverting it back to ancient buggy prototype code. My
> understanding was that Benny was rightly ripping out the reversions at
> bakeathon.
>
OK that figures then. I was using the only tree I could use,
I guess I'll have to wait out until things settle.
> Fred
However with the tree released by benny few hours ago I get
a new crash. The uml backtrace is really bad I'll try to print
out more context to see where was the last put done.
This time it takes a long time to trigger. It feels like
a race.
Call Trace:
602678a8: [<6001585b>] panic_exit+0x2f/0x45
602678c8: [<60049a3e>] notifier_call_chain+0x32/0x5e
60267908: [<60049a8c>] atomic_notifier_call_chain+0x13/0x15
60267918: [<601b3b9b>] panic+0x105/0x1dc
602679c8: [<601b6056>] _raw_spin_unlock_irqrestore+0x18/0x1c
602679e8: [<60016e5f>] free_irqs+0x74/0xde
60267a18: [<60015162>] relay_signal+0x38/0x79
60267a28: [<60012cef>] sigio_handler+0x5a/0x5f
60267a48: [<600224d0>] sig_handler_common+0x84/0x98
60267a68: [<6002257d>] real_alarm_handler+0x3c/0x3e
60267af0: [<60186de1>] tcp_rcv_established+0x107/0x5fa
60267b78: [<60022616>] sig_handler+0x30/0x3b
60267b98: [<60022848>] handle_signal+0x6d/0xa3
60267be8: [<600241c8>] hard_handler+0x10/0x14
60267ca8: [<7b9cdaa3>] destroy_layout_hdr+0x33/0x52 [nfs]
(gdb) list *(destroy_layout_hdr+0x33)
0x2eac7 is in destroy_layout_hdr (/usr0/export/dev/bharrosh/git/pub/linux-pnfs/fs/nfs/pnfs.c:262).
257
258 static void
259 destroy_layout_hdr(struct pnfs_layout_hdr *lo)
260 {
261 dprintk("%s: freeing layout cache %p\n", __func__, lo);
262 BUG_ON(!list_empty(&lo->plh_layouts));
263 NFS_I(lo->plh_inode)->layout = NULL;
264 pnfs_free_layout_hdr(lo);
265 }
266
prev parent reply other threads:[~2011-02-28 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:42 Client still crashing on 2nd callback after NFS4_ERR_DELAY Boaz Harrosh
2011-02-27 15:04 ` [PATCH] SQUASHME: pnfs: FIX stupid recall_layout BUG Boaz Harrosh
2011-02-27 22:09 ` Fred Isaman
2011-02-28 18:24 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6BE865.7010307@panasas.com \
--to=bharrosh@panasas.com \
--cc=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).