linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: [PATCH 3/2] mount: Allow 'port=0' to be a valid port value.
Date: Thu, 03 Mar 2011 15:04:54 -0500	[thread overview]
Message-ID: <4D6FF466.2070004@RedHat.com> (raw)
In-Reply-To: <1299159822-25190-1-git-send-email-kzak@redhat.com>

With the new util-linux, /etc/mtab is now is symbolically linked
to /proc/mounts. In /proc/mounts, the 'port=0' exits which causes
the umount.nfs to error out with the following error:
   umount.nfs: invalid value for 'port=' option

Setting port=0 is a valid value. It just means go out and query
remote rpcbind to get the correct port.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/mount/network.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utils/mount/network.c b/utils/mount/network.c
index 8049c1a..88ab222 100644
--- a/utils/mount/network.c
+++ b/utils/mount/network.c
@@ -1346,7 +1346,7 @@ nfs_nfs_port(struct mount_options *options, unsigned long *port)
 	case PO_NOT_FOUND:
 		break;
 	case PO_FOUND:
-		if (tmp >= 1 && tmp <= 65535) {
+		if (tmp >= 0 && tmp <= 65535) {
 			*port = tmp;
 			return 1;
 		}

  parent reply	other threads:[~2011-03-03 20:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 13:43 mount.nfs libmount support (v2) Karel Zak
2011-03-03 13:43 ` [PATCH 1/2] mount: move generic functions to utils.c and network.c Karel Zak
2011-03-03 20:03   ` [PATCH 1.5/2] mount: Remove MOUNT_CONFIG warning Steve Dickson
     [not found]     ` <4D6FF3F4.8040602-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2011-03-05 21:24       ` Steve Dickson
2011-03-03 13:43 ` [PATCH 2/2] mount: add --enable-libmount-mount Karel Zak
2011-03-03 19:53   ` Steve Dickson
2011-03-04 10:18     ` Karel Zak
2011-03-04 16:23       ` Steve Dickson
2011-03-03 14:48 ` mount.nfs libmount support (v2) Chuck Lever
2011-03-03 20:04 ` Steve Dickson [this message]
2011-03-03 20:12   ` [PATCH 3/2] mount: Allow 'port=0' to be a valid port value Chuck Lever
2011-03-03 20:16     ` Chuck Lever
2011-03-03 20:38       ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6FF466.2070004@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=kzak@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).