From: Mi Jinlong <mijinlong@cn.fujitsu.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd41: make sure nfs server process OPEN with EXCLUSIVE4_1 correcttly
Date: Fri, 08 Apr 2011 17:57:25 +0800 [thread overview]
Message-ID: <4D9EDC05.2080809@cn.fujitsu.com> (raw)
In-Reply-To: <20110407195005.GC11806@fieldses.org>
J. Bruce Fields :
> On Wed, Apr 06, 2011 at 05:04:50PM +0800, Mi Jinlong wrote:
>> At the recent kernel(2.6.39-rc1),
>
> (But this is not a regression, right? This has been a problem all
> along.)
Yes, I think it's just a problem.
>
>> NFS server can't process OPEN with EXCLUSIVE4_1,
>> because NFS server call nfsd_create_v3 to create file instead implement a separate
>> one. But nfsd_create_v3 can't process createmode is EXCLUSIVE4_1.
>
> Is our handling of the attributes correct in this case? (See e.g. the
> op_bmval[1] assignment a few lines down.)
There is no problem of the p_bmval[1] assignment a few lines down.
According to rfc5661 18.16.3, EXCLUSIVE4_1 supports the setting of
attributes at file creation, we don't need to set p_bmval[1] assignment
as EXCLUSIVE.
I think we should have a fix at nfsd_create_v3(), not at do_open_lookup().
Please ignore the old patch, a new one is as following.
--
thanks,
Mi Jinlong
=============================================================================
next prev parent reply other threads:[~2011-04-08 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 9:04 [PATCH] nfsd41: make sure nfs server process OPEN with EXCLUSIVE4_1 correcttly Mi Jinlong
2011-04-07 19:50 ` J. Bruce Fields
2011-04-08 9:57 ` Mi Jinlong [this message]
2011-04-18 20:07 ` J. Bruce Fields
2011-04-20 9:20 ` Mi Jinlong
2011-04-20 21:00 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9EDC05.2080809@cn.fujitsu.com \
--to=mijinlong@cn.fujitsu.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).