Linux NFS development
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfs-utils:  Support binding to source address.
Date: Thu, 09 Jun 2011 16:48:52 -0700	[thread overview]
Message-ID: <4DF15BE4.6080709@candelatech.com> (raw)
In-Reply-To: <4DF13A43.6020500@candelatech.com>

On 06/09/2011 02:25 PM, Ben Greear wrote:
> On 06/09/2011 02:16 PM, Steve Dickson wrote:

> How about an initial patch that just passes a container down
> to the bind logic with the 'sap' and 'salen' into a container struct.
>
> Should have zero functionality change, but fairly large patch
> (basically the same places as where I added the 'local_ip' argument).
>
> Then, I can post a patch to enable packaging a src-addr in that
> container as well. That should be a much smaller patch and so
> may seem less scary.

I gave this a try and it started looking very ugly.

I'll work on breaking my previously posted patch smaller
chunks.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2011-06-09 23:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 23:01 [PATCH v2] nfs-utils: Support binding to source address greearb
2011-06-09 14:05 ` Chuck Lever
2011-06-09 15:50   ` Ben Greear
2011-06-09 18:39     ` Chuck Lever
2011-06-09 23:47       ` Ben Greear
2011-06-09 17:18 ` Steve Dickson
2011-06-09 17:29   ` Ben Greear
2011-06-09 21:16     ` Steve Dickson
2011-06-09 21:25       ` Ben Greear
2011-06-09 23:48         ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF15BE4.6080709@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox