From: Mi Jinlong <mijinlong@cn.fujitsu.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: Jim Rees <rees@umich.edu>, Chuck Lever <chuck.lever@oracle.com>,
NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] rpc.mountd: let mountd consult /etc/services for port
Date: Fri, 10 Jun 2011 16:23:41 +0800 [thread overview]
Message-ID: <4DF1D48D.10403@cn.fujitsu.com> (raw)
In-Reply-To: <4DEE873F.70607@RedHat.com>
Steve Dickson:
> On 05/28/2011 12:45 PM, Jim Rees wrote:
>> Chuck Lever wrote:
>>
>> So, we could also address this by getting rid of the legacy RPC behavior
>> instead. However, in cases like this, I typically choose to stick with
>> legacy behavior, since that improves backwards compatibility. It already
>> works like this for legacy RPC builds, so in some sense we are stuck with
>> it.
>>
>> Ok. I remember the earlier discussion but forgot that the patch simply
>> restores older behavior that was changed by tirpc. In that case I'll go
>> along with Mi's patch.
> I am all for restoring the older behavior, but unfortunately this patch
> does not do it.
>
> I when back and took a look at how the nfs-utils-1.2.2 code worked.
> While its true both mountd and statd read ports from /etc/service,
> they did not fail when those ports were already taken. They just
> bound to random ephemeral ports, which is probably the reason none of
> us noticed they were reading ports out of /etc/services. With
> Mi's patch, both daemons fail when the ports in /etc/service are
> already taken.
Hi steve,
Do you mean the daemons can't run?
I test nfs-utils-1.2.2 at fedora15, mountd can bind to the port
reading form /etc/service.
So, can you post some error or other message here?
thanks,
Mi Jinlong
next prev parent reply other threads:[~2011-06-10 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 8:33 [PATCH] svc: make sure mountd can get ports from /etc/services Mi Jinlong
2011-04-19 13:28 ` Chuck Lever
2011-04-20 9:29 ` Mi Jinlong
2011-04-20 15:08 ` Chuck Lever
2011-04-21 3:42 ` Mi Jinlong
2011-04-21 14:11 ` Chuck Lever
2011-04-25 7:09 ` Mi Jinlong
2011-04-25 15:58 ` Chuck Lever
2011-05-28 9:42 ` [PATCH v2] rpc.mountd: let mountd consult /etc/services for port Mi Jinlong
2011-05-28 13:29 ` Jim Rees
2011-05-28 16:01 ` Chuck Lever
2011-05-28 16:45 ` Jim Rees
2011-06-07 20:17 ` Steve Dickson
2011-06-10 8:23 ` Mi Jinlong [this message]
2011-08-03 17:52 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF1D48D.10403@cn.fujitsu.com \
--to=mijinlong@cn.fujitsu.com \
--cc=SteveD@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).