From: Ben Greear <greearb@candelatech.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 4/7] nfs-utils: Implement srcaddr binding in network.c
Date: Fri, 10 Jun 2011 11:40:25 -0700 [thread overview]
Message-ID: <4DF26519.2030507@candelatech.com> (raw)
In-Reply-To: <7BC92EC0-31CE-4A5D-85F8-E409E812A819@oracle.com>
On 06/10/2011 11:29 AM, Chuck Lever wrote:
>
> On Jun 10, 2011, at 2:09 PM, greearb@candelatech.com wrote:
>
>> From: Ben Greear<greearb@candelatech.com>
>>
>> Implement binding logic in get_socket() if local_ip
>> argument is not NULL.
>>
>> Note that this method had issues with supporting IPv6 before
>> this patch, and this patch does NOT resolve them.
>
> If get_socket() doesn't support IPv6, then I doubt it's used for string-based mounts. You may not need any changes here.
Looks like you are correct. I added printf to that method and
see nothing while doing mount/unmount. I'll respin the patches
to remove that...should make things a good bit smaller.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-06-10 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 18:09 [PATCH 0/7] nfs-utils: Support binding to source address greearb
2011-06-10 18:09 ` [PATCH 1/7] nfs-utils: Add structure for passing local binding info greearb
2011-06-10 18:09 ` [PATCH 2/7] nfs-utils: Add patch to parse srcaddr= option greearb
2011-06-10 18:09 ` [PATCH 3/7] nfs-utils: Implement srcaddr binding in rpc_socket greearb
2011-06-10 18:09 ` [PATCH 4/7] nfs-utils: Implement srcaddr binding in network.c greearb
2011-06-10 18:29 ` Chuck Lever
2011-06-10 18:40 ` Ben Greear [this message]
2011-06-10 18:09 ` [PATCH 5/7] nfs-utils: Support srcaddr=n option for string mount greearb
2011-06-10 18:39 ` Chuck Lever
2011-06-10 18:09 ` [PATCH 6/7] nfs-utils: Implement srcaddr=n binding for unmount greearb
2011-06-10 18:09 ` [PATCH 7/7] nfs-utils: Update man page for srcaddr= option greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF26519.2030507@candelatech.com \
--to=greearb@candelatech.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).