From: Benny Halevy <bhalevy@panasas.com>
To: 于浩 <haohaoweixiao@hotmail.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: In the linux-all-2.6.38 of pnfs, why was pnfs_return_layout removed ?
Date: Thu, 16 Jun 2011 11:28:30 -0400 [thread overview]
Message-ID: <4DFA211E.5040103@panasas.com> (raw)
In-Reply-To: <BLU0-SMTP135422B057EEE4C3CA3C9DEAB6A0@phx.gbl>
Steven, the call was removed to accommodate for the "forgetful client" model
where the client drops its layout unilaterally and the server is supposed
to clean up the client layout on its side.
We are bringing it back, correctly, with proper synchronization, in Linux 3.0
in so that the layout will be returned in nfs_evict_inode.
What server are you testing?
Does the layouts it provides marked with return_on_close?
If so, I pulled a patch from Boaz into pnfs-all-2.6.39 for automatically cleaning up
return_on_close layouts on the server side after a forgetful client closes the file
without returning them.
Benny
On 2011-06-16 10:52, 于浩 wrote:
>
> Dear All,
> Dear All,
> I got one problem when testing the read performance of linux-all-2.6.38. I found that the speed was becoming slower with time.(300MB/s-->50MB/s). Finally,I found the cause of the problem. In __nfs4_close(), the "LAYOUT RETURN" operation was removed. So the size of "layout_hash" becomes bigger and bigger on the pnfs server side. Then more time is spent on searching in __layout_inode_find() function. I wonder why the pnfs_return_layout() in __nfs4_close() was removed ??
>
> Regards,
> Steven.
>
> ----------------------------------------------------------------------
> SQUASHME: pnfs: revert layout recall/get/return synchronization
> authorBenny Halevy <bhalevy@panasas.com>
> Thu, 24 Feb 2011 02:53:46 +0000 (18:53 -0800)
> committerBenny Halevy <bhalevy@panasas.com>
> Fri, 25 Mar 2011 08:25:57 +0000 (10:25 +0200)
>
> For now, revert code attempting a "forget-less" client model to match
> the pnfs-submit-wave4 forgetful model implementation in preparation
> for porting the tree onto it.
>
> Signed-off-by: Benny Halevy bhalevy@panasas.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-16 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 14:52 In the linux-all-2.6.38 of pnfs, why was pnfs_return_layout removed ? 于浩
2011-06-16 15:28 ` Benny Halevy [this message]
[not found] ` <SNT136-w5258CE4C76C7D063BA95EBAB6D0@phx.gbl>
2011-06-17 13:52 ` Benny Halevy
2011-06-21 16:01 ` Is there any release note for one pnfs release version ？ 于浩
2011-06-23 6:47 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA211E.5040103@panasas.com \
--to=bhalevy@panasas.com \
--cc=haohaoweixiao@hotmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).