From: Bryan Schumaker <bjschuma@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] NFSD: Added TEST_STATEID operation
Date: Wed, 29 Jun 2011 16:34:38 -0400 [thread overview]
Message-ID: <4E0B8C5E.1090505@netapp.com> (raw)
In-Reply-To: <20110629195447.GC3279@fieldses.org>
On 06/29/2011 03:54 PM, J. Bruce Fields wrote:
> On Wed, Jun 29, 2011 at 03:49:10PM -0400, Bryan Schumaker wrote:
>> On 05/20/2011 04:13 PM, bjschuma@netapp.com wrote:
>>> +__be32
>>> +nfsd4_do_test_stateid(stateid_t *stateid, int flags)
>>> +{
>>> + __be32 ret = nfs4_validate_stateid(stateid, flags);
>>> + if (!ret)
>>> + ret = nfs4_validate_stateid(stateid, flags);
>>> + return ret;
>>
>> Looking back at this, I'm not convinced that I need to call nfs4_validate_stateid() twice with the same stateid and flags. What is the status of these patches? Should I resubmit everything or send in a small patch to fix this?
>
> Whoops, lazy review on my part....
>
> Looks like I'd applied that locally but not pushed it out to my public
> tree yet, so I could still take a replacement.
Ok, sounds good.
>
> How are you testing these, by the way? On second thoughts, I think I
> may have already asked you that, and forgotten the answer, so don't
> bother answering here--just add some text to the changelog and then I'll
> know how to find the answer next time.
I found this as I was going through my fault injection code. I'm going to double check these with my fault injection changes and then try to send in updates for both next week.
- Bryan
>
> --b.
next prev parent reply other threads:[~2011-06-29 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 20:12 [PATCH v2 0/2] NFSD: add FREE_STATEID and TEST_STATEID operations bjschuma
2011-05-20 20:12 ` [PATCH 1/2] NFSD: added FREE_STATEID operation bjschuma
2011-05-20 20:16 ` Bryan Schumaker
2011-05-25 15:05 ` J. Bruce Fields
2011-05-31 14:52 ` Bryan Schumaker
2011-05-20 20:13 ` [PATCH 2/2] NFSD: Added TEST_STATEID operation bjschuma
2011-06-29 19:49 ` Bryan Schumaker
2011-06-29 19:54 ` J. Bruce Fields
2011-06-29 20:34 ` Bryan Schumaker [this message]
2011-06-29 20:40 ` J. Bruce Fields
2011-07-12 10:59 ` J. Bruce Fields
2011-07-12 12:40 ` Bryan Schumaker
2011-07-12 12:42 ` J. Bruce Fields
2011-05-20 20:13 ` [PATCH v2 0/2] NFSD: add FREE_STATEID and TEST_STATEID operations Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0B8C5E.1090505@netapp.com \
--to=bjschuma@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).