From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.candelatech.com ([208.74.158.172]:53009 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156Ab1GGV0Z (ORCPT ); Thu, 7 Jul 2011 17:26:25 -0400 Message-ID: <4E16247D.4060307@candelatech.com> Date: Thu, 07 Jul 2011 14:26:21 -0700 From: Ben Greear To: greearb@candelatech.com CC: linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 00/12] NFS: Support binding to source address References: <1308857388-12243-1-git-send-email-greearb@candelatech.com> In-Reply-To: <1308857388-12243-1-git-send-email-greearb@candelatech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 06/23/2011 12:29 PM, greearb@candelatech.com wrote: > From: Ben Greear > > This lets one specify the source IP address for > sockets, allowing users to leverage routing rules > on multi-homed systems. > > Patches are also needed to nfs-utils. These have been > posted and will be accepted if the kernel support is > accepted. > > v2: Add patch 11 to bind the NLM client to the proper > source address as well. Any comments on these patches? Now that the work-queue v/s rpc_killall_tasks race has been fixed, this code appears stable under heavy load. I'd love to see this accepted upstream! Thanks, Ben > > Ben Greear (12): > sunrpc: Don't attempt to bind to AF_UNSPEC address. > nfs: Two AF_UNSPEC addresses should always match each other. > nfs: Add srcaddr member to nfs_client. > nfs: Use request destination addr as callback source addr. > nfs: Pay attention to srcaddr in v4.1 callback logic. > nfs: Use srcaddr in nfs_match_client. > nfs: Add srcaddr to /proc/fs/nfsfs/servers > nfs: Pass srcaddr into mount request. > nfs: Propagate src-addr in client code. > nfs: Bind to srcaddr in rpcb_create. > lockd: Support binding nlm client to specific address. > nfs: Support srcaddr= to bind to specific IP address. > > fs/lockd/clntlock.c | 3 +- > fs/lockd/host.c | 17 +++++++++- > fs/nfs/callback.h | 3 ++ > fs/nfs/callback_proc.c | 3 +- > fs/nfs/callback_xdr.c | 3 ++ > fs/nfs/client.c | 73 ++++++++++++++++++++++++++++++++++++++++-- > fs/nfs/internal.h | 10 +++++- > fs/nfs/mount_clnt.c | 1 + > fs/nfs/super.c | 33 +++++++++++++++++++- > include/linux/lockd/bind.h | 1 + > include/linux/lockd/lockd.h | 1 + > include/linux/nfs_fs_sb.h | 4 ++ > include/linux/sunrpc/clnt.h | 2 + > include/linux/sunrpc/svc.h | 5 +++ > net/sunrpc/rpcb_clnt.c | 28 +++++++++++++++- > net/sunrpc/sunrpc.h | 45 ++++++++++++++++++++++++++ > net/sunrpc/xprtsock.c | 47 +-------------------------- > 17 files changed, 223 insertions(+), 56 deletions(-) > -- Ben Greear Candela Technologies Inc http://www.candelatech.com