From: Benny Halevy <bhalevy@tonian.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Jim Rees <rees@umich.edu>,
linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH v3 01/25] pnfs: GETDEVICELIST
Date: Thu, 28 Jul 2011 14:27:53 -0400 [thread overview]
Message-ID: <4E31AA29.4060308@tonian.com> (raw)
In-Reply-To: <1311795219.25645.9.camel@lade.trondhjem.org>
On 2011-07-27 15:33, Trond Myklebust wrote:
> On Wed, 2011-07-27 at 14:40 -0400, Jim Rees wrote:
>> From: Andy Adamson <andros@netapp.com>
...
>> @@ -6902,6 +7029,7 @@ struct rpc_procinfo nfs4_procedures[] = {
>> PROC(GET_LEASE_TIME, enc_get_lease_time, dec_get_lease_time),
>> PROC(RECLAIM_COMPLETE, enc_reclaim_complete, dec_reclaim_complete),
>> PROC(GETDEVICEINFO, enc_getdeviceinfo, dec_getdeviceinfo),
>> + PROC(GETDEVICELIST, enc_getdevicelist, dec_getdevicelist),
>
> This needs to go at the end of the list of procedures in order to work
> correctly with nfsstat.
>
FWIW, what matters is the value of NFSPROC4_CLNT_GETDEVICELIST
rather than the order of instantiation of the PROC() macro.
It is defined in end of the respective enum in include/linux/nfs4.h.
Benny
>> PROC(LAYOUTGET, enc_layoutget, dec_layoutget),
>> PROC(LAYOUTCOMMIT, enc_layoutcommit, dec_layoutcommit),
>> PROC(LAYOUTRETURN, enc_layoutreturn, dec_layoutreturn),
>
>
next prev parent reply other threads:[~2011-07-28 18:27 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 18:40 [PATCH v3 00/25] add block layout driver to pnfs client Jim Rees
2011-07-27 18:40 ` [PATCH v3 01/25] pnfs: GETDEVICELIST Jim Rees
2011-07-27 19:33 ` Trond Myklebust
2011-07-28 18:27 ` Benny Halevy [this message]
2011-07-27 18:40 ` [PATCH v3 02/25] pnfs: add set-clear layoutdriver interface Jim Rees
2011-07-27 19:36 ` Trond Myklebust
2011-07-27 18:40 ` [PATCH v3 03/25] NFS41: Let layoutcommit handle multiple segments Jim Rees
2011-07-27 20:05 ` Boaz Harrosh
2011-07-27 20:22 ` Trond Myklebust
2011-07-27 20:33 ` Boaz Harrosh
2011-07-27 20:58 ` Jim Rees
2011-07-27 21:09 ` Boaz Harrosh
2011-07-27 23:40 ` Jim Rees
2011-07-28 0:12 ` Boaz Harrosh
2011-07-28 2:02 ` tao.peng
2011-07-28 3:19 ` Jim Rees
2011-07-27 18:40 ` [PATCH v3 04/25] NFS41: save layoutcommit cred after first successful layoutget Jim Rees
2011-07-27 19:47 ` Trond Myklebust
2011-07-28 3:29 ` tao.peng
2011-07-27 18:40 ` [PATCH v3 05/25] pnfs: ask for layout_blksize and save it in nfs_server Jim Rees
2011-07-27 18:40 ` [PATCH v3 06/25] pnfs: cleanup_layoutcommit Jim Rees
2011-07-27 19:53 ` Trond Myklebust
2011-07-27 20:20 ` Boaz Harrosh
2011-07-27 20:25 ` Trond Myklebust
2011-07-27 20:42 ` Boaz Harrosh
2011-07-27 20:59 ` Trond Myklebust
2011-07-27 21:33 ` Boaz Harrosh
2011-07-27 18:40 ` [PATCH v3 07/25] pnfsblock: add blocklayout Kconfig option, Makefile, and stubs Jim Rees
2011-07-27 18:40 ` [PATCH v3 08/25] pnfsblock: basic extent code Jim Rees
2011-07-27 18:40 ` [PATCH v3 09/25] pnfsblock: add device operations Jim Rees
2011-07-27 18:40 ` [PATCH v3 10/25] pnfsblock: remove " Jim Rees
2011-07-27 18:40 ` [PATCH v3 11/25] pnfsblock: lseg alloc and free Jim Rees
2011-07-27 18:40 ` [PATCH v3 12/25] pnfsblock: merge extents Jim Rees
2011-07-27 18:40 ` [PATCH v3 13/25] pnfsblock: call and parse getdevicelist Jim Rees
2011-07-27 18:40 ` [PATCH v3 14/25] pnfsblock: xdr decode pnfs_block_layout4 Jim Rees
2011-07-27 18:40 ` [PATCH v3 15/25] pnfsblock: bl_find_get_extent Jim Rees
2011-07-27 18:40 ` [PATCH v3 16/25] pnfsblock: add extent manipulation functions Jim Rees
2011-07-27 18:40 ` [PATCH v3 17/25] pnfsblock: merge rw extents Jim Rees
2011-07-27 18:40 ` [PATCH v3 18/25] pnfsblock: encode_layoutcommit Jim Rees
2011-07-27 18:40 ` [PATCH v3 19/25] pnfsblock: cleanup_layoutcommit Jim Rees
2011-07-27 18:40 ` [PATCH v3 20/25] pnfsblock: bl_read_pagelist Jim Rees
2011-07-27 20:09 ` Trond Myklebust
2011-07-27 18:40 ` [PATCH v3 21/25] pnfsblock: bl_write_pagelist Jim Rees
2011-07-27 20:11 ` Trond Myklebust
2011-07-27 18:40 ` [PATCH v3 22/25] pnfsblock: note written INVAL areas for layoutcommit Jim Rees
2011-07-27 20:13 ` Trond Myklebust
2011-07-28 2:30 ` tao.peng
2011-07-27 18:40 ` [PATCH v3 23/25] pnfsblock: use pageio_ops api Jim Rees
2011-07-27 20:15 ` Trond Myklebust
2011-07-28 2:27 ` tao.peng
2011-07-28 3:52 ` Trond Myklebust
2011-07-28 4:10 ` tao.peng
2011-07-27 18:40 ` [PATCH v3 24/25] pnfsblock: write_pagelist handle zero invalid extents Jim Rees
2011-07-27 18:40 ` [PATCH v3 25/25] NFS41: Drop lseg ref before fallthru to MDS Jim Rees
2011-07-27 20:16 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E31AA29.4060308@tonian.com \
--to=bhalevy@tonian.com \
--cc=Trond.Myklebust@netapp.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).