linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>,
	Jim Rees <rees@umich.edu>, Peng Tao <bergwolf@gmail.com>,
	NFS list <linux-nfs@vger.kernel.org>
Subject: [PATCHSET 0/6] Patches needed for Stable
Date: Fri, 29 Jul 2011 23:19:52 -0700	[thread overview]
Message-ID: <4E33A288.80403@panasas.com> (raw)

Trond Hi

I've played all day with these commit patches and I came to the conclusion
that we will need all 5 of Peng's commit patches. The minimal set is the first
4 and without the 5th one, is as you pointed out, might be very racy. Let me
explain.

At first I thought all I needed was:
	[PATCH v4 05/27] pnfs: let layoutcommit handle a list of lseg
	[PATCH v4 06/27] pnfs: use lwb as layoutcommit length

But They do not apply as is, and would not work. 
I tried to, instead of taking the creds and lwb from the *header*, take them
from the *first segment*. But this is an ugly hack (I tried, it's really ugly)
and is scary as hell. Because it is code we never tested as opposed to this code
that was the only one I actually tested since before last bakeathon. I would
hate to put such under-tested code in Stable when we will change it hopefully
in this Kernel and is ugly as hell.

So Introducing these two:
	[PATCH v4 03/27] pnfs: save layoutcommit lwb at layout header
	[PATCH v4 04/27] pnfs: save layoutcommit cred at layout header
Just makes sense.

Now also:
	[PATCH v4 07/27] NFS41: save layoutcommit cred in layout header init

Was pointed by you as fixing a potential race, which I agree completely, and
I think it should be just merged with:
	[PATCH 2/6] pnfs: save layoutcommit cred at layout header
Which are the same exact issue only done better

I'm adding two more patches I'll need for Stable which are bug fixes we found
in the large testing we did here after Bakeathon:
	[PATCH 5/6] pnfs-obj: Bug when we are running out of bio
	[PATCH 6/6] pnfs-obj: Fix the comp_index != 0 case

----
So here is the list of patches for stable:

[PATCH 1/6] pnfs: save layoutcommit lwb at layout header
[PATCH 2/6] pnfs: save layoutcommit cred at layout header init
[PATCH 3/6] pnfs: let layoutcommit handle a list of lseg
[PATCH 4/6] pnfs: use lwb as layoutcommit length

	These 4 are Peng's 5 layoutcommit patches. I've combined 
	  [PATCH v4 04/27] pnfs: save layoutcommit cred at layout header
	and
	  [PATCH v4 07/27] NFS41: save layoutcommit cred in layout header init
	Which are just the same issue. And rebased the last one on top of that.
	And added CC: Stable.

[PATCH 5/6] pnfs-obj: Bug when we are running out of bio
[PATCH 6/6] pnfs-obj: Fix the comp_index != 0 case

Thanks
Boaz

             reply	other threads:[~2011-07-30  6:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-30  6:19 Boaz Harrosh [this message]
2011-07-30  6:29 ` [PATCH 1/6] pnfs: save layoutcommit lwb at layout header Boaz Harrosh
2011-07-30  6:30 ` [PATCH 2/6] pnfs: save layoutcommit cred at layout header init Boaz Harrosh
2011-07-30  6:32 ` [PATCH 3/6] pnfs: let layoutcommit handle a list of lseg Boaz Harrosh
2011-07-30  6:33 ` [PATCH 4/6] pnfs: use lwb as layoutcommit length Boaz Harrosh
2011-07-30  6:34 ` [PATCH 5/6] pnfs-obj: Bug when we are running out of bio Boaz Harrosh
2011-07-30  6:35 ` [PATCH 6/6] pnfs-obj: Fix the comp_index != 0 case Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E33A288.80403@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bergwolf@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rees@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).