From: Steve Dickson <SteveD@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mount: fix for libmount from util-linux >= 2.20
Date: Wed, 03 Aug 2011 15:14:10 -0400 [thread overview]
Message-ID: <4E399E02.4010702@RedHat.com> (raw)
In-Reply-To: <1312374969-15726-1-git-send-email-kzak@redhat.com>
On 08/03/2011 08:36 AM, Karel Zak wrote:
> The function mnt_fs_set_fs_options() has been removed from the final
> version of the libmount API.
>
> Signed-off-by: Karel Zak <kzak@redhat.com>
Committed...
steved.
> ---
> utils/mount/mount_libmount.c | 15 ++++++++++++---
> 1 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/utils/mount/mount_libmount.c b/utils/mount/mount_libmount.c
> index 6dd6484..cf6e58c 100644
> --- a/utils/mount/mount_libmount.c
> +++ b/utils/mount/mount_libmount.c
> @@ -61,10 +61,19 @@ int nomtab;
> * managed by libmount at all. We have to use "mount attributes" that are
> * private for mount.<type> helpers.
> */
> -static void store_mount_options(struct libmnt_fs *fs, const char *opts)
> +static void store_mount_options(struct libmnt_fs *fs, const char *nfs_opts)
> {
> - mnt_fs_set_fs_options(fs, opts); /* for mtab */
> - mnt_fs_set_attributes(fs, opts); /* for non-mtab systems */
> + char *o = NULL;
> +
> + mnt_fs_set_attributes(fs, nfs_opts); /* for non-mtab systems */
> +
> + /* for mtab create a new options list */
> + mnt_optstr_append_option(&o, mnt_fs_get_vfs_options(fs), NULL);
> + mnt_optstr_append_option(&o, nfs_opts, NULL);
> + mnt_optstr_append_option(&o, mnt_fs_get_user_options(fs), NULL);
> +
> + mnt_fs_set_options(fs, o);
> + free(o);
> }
>
> /*
prev parent reply other threads:[~2011-08-03 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 12:36 [PATCH] mount: fix for libmount from util-linux >= 2.20 Karel Zak
2011-08-03 19:14 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E399E02.4010702@RedHat.com \
--to=steved@redhat.com \
--cc=kzak@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).