From: Benny Halevy <benny@tonian.com>
To: Jim Rees <rees@umich.edu>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
Peng Tao <bergwolf@gmail.com>,
linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH] pnfsblock: add missing rpc_put_mount and path_put
Date: Mon, 19 Sep 2011 06:01:22 +0300 [thread overview]
Message-ID: <4E76B082.6000500@tonian.com> (raw)
In-Reply-To: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430B35602C@SACMVEXC2-PRD.hq.netapp.com>
On 2011-09-19 05:06, Myklebust, Trond wrote:
>> -----Original Message-----
>> From: Jim Rees [mailto:rees@umich.edu]
>> Sent: Sunday, September 18, 2011 10:05 PM
>> To: Myklebust, Trond
>> Cc: Benny Halevy; Peng Tao; linux-nfs@vger.kernel.org; peter honeyman
>> Subject: Re: [PATCH] pnfsblock: add missing rpc_put_mount and path_put
>>
>> Myklebust, Trond wrote:
>>
>> > -----Original Message-----
>> > From: Benny Halevy [mailto:bhalevy@tonian.com]
>> > Sent: Wednesday, September 14, 2011 6:20 AM
>> > To: Jim Rees; Peng Tao; Myklebust, Trond
>> > Cc: linux-nfs@vger.kernel.org; peter honeyman
>> > Subject: Re: [PATCH] pnfsblock: add missing rpc_put_mount and
> path_put
>> >
>> > We need to decide on a process here :)
>> > If we would like to maintain a staging tree in front of Trond's
> then
>> to simplify
>> > merging and rebasing, fixes to code that's already upstream, i.e.
> in
>> linux-2.6
>> > or already queued in nfs-2.6, that we decide to send to Trond
> ahead of
>> > queue need to be queued in front of stuff in the staging tree and
> the
>> latter
>> > should be rebased on top of them.
>>
>> Unless we're talking about a large merge, I tend to prefer patches.
> They
>> are much easier to review...
>>
>> I guess the problem is that we now have a patch in Trond's tree that
> conflicts
>> with the workqueue patch that's staged for later in Benny's tree.
>> I think what I need to do is send Benny a set of patches that starts
> with the
>> same patch I sent Trond, and follows with one that adds the workqueue.
>
> Yes. That's the other good feature of patches: the onus of fixing up
> conflicts is on you and not on me... :-)
>
Right. If the required rebase is not trivial I prefer you do it
for many reasons, including familiarity with the change and testing
the end result. Then, either send the patchset to the list and/or
point me to a branch in your tree for me to get the series from
Benny
> Trond
next prev parent reply other threads:[~2011-09-19 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 20:24 [PATCH] pnfsblock: add missing rpc_put_mount and path_put Jim Rees
2011-09-14 10:19 ` Benny Halevy
2011-09-19 1:09 ` Myklebust, Trond
2011-09-19 2:04 ` Jim Rees
2011-09-19 2:06 ` Myklebust, Trond
2011-09-19 3:01 ` Benny Halevy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-13 16:16 Peng Tao
2011-09-13 16:44 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E76B082.6000500@tonian.com \
--to=benny@tonian.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bergwolf@gmail.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).