From: Bryan Schumaker <bjschuma@netapp.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/3] NFS: Clean up nfs4_xdr_dec_secinfo()
Date: Thu, 27 Oct 2011 06:51:06 -0400 [thread overview]
Message-ID: <4EA9379A.10605@netapp.com> (raw)
In-Reply-To: <20111025161753.5996.83383.stgit@seurat.1015granger.net>
On 10/25/2011 12:17 PM, Chuck Lever wrote:
> Clean up: Remove superfluous logic at the tail of
> nfs4_xdr_dec_secinfo() .
Oops. Good catch!
- Bryan
>
> Introduced by commit 5a5ea0d4 "NFS: Add secinfo procedure" (March 24,
> 2011).
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> fs/nfs/nfs4xdr.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 1dce12f..e6161b2 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -6602,8 +6602,6 @@ static int nfs4_xdr_dec_secinfo(struct rpc_rqst *rqstp,
> if (status)
> goto out;
> status = decode_secinfo(xdr, res);
> - if (status)
> - goto out;
> out:
> return status;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-10-27 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 16:17 [PATCH 0/3] Three tiny clean-ups for 3.2 (repost) Chuck Lever
2011-10-25 16:17 ` [PATCH 1/3] NFS: Fix documenting comment for nfs_create_request() Chuck Lever
2011-10-25 16:17 ` [PATCH 2/3] NFS: Clean up nfs4_xdr_dec_secinfo() Chuck Lever
2011-10-27 10:51 ` Bryan Schumaker [this message]
2011-10-25 16:18 ` [PATCH 3/3] NFS: Remove no-op less-than-zero checks on unsigned variables Chuck Lever
-- strict thread matches above, loose matches on Subject: below --
2011-09-26 15:29 [PATCH 0/3] Three tiny clean-ups for 3.2 Chuck Lever
2011-09-26 15:30 ` [PATCH 2/3] NFS: Clean up nfs4_xdr_dec_secinfo() Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA9379A.10605@netapp.com \
--to=bjschuma@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).