From: Bryan Schumaker <bjschuma@netapp.com>
To: andros@netapp.com
Cc: trond.myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug
Date: Fri, 04 Nov 2011 10:40:23 -0400 [thread overview]
Message-ID: <4EB3F957.2060309@netapp.com> (raw)
In-Reply-To: <1318919979-14606-1-git-send-email-andros@netapp.com>
"backchennel" in the subject should be "backchannel"
- Bryan
On 10/18/2011 02:39 AM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> Slotid's start from 0 which means we check against
> NFS41_BC_MAX_CALLBACKS - 1.
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
> fs/nfs/callback_proc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
> index 98ff5fc..12bd9d0 100644
> --- a/fs/nfs/callback_proc.c
> +++ b/fs/nfs/callback_proc.c
> @@ -339,7 +339,7 @@ validate_seqid(struct nfs4_slot_table *tbl, struct cb_sequenceargs * args)
> dprintk("%s enter. slotid %d seqid %d\n",
> __func__, args->csa_slotid, args->csa_sequenceid);
>
> - if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS)
> + if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS - 1)
> return htonl(NFS4ERR_BADSLOT);
>
> slot = nfs4_lookup_slot_locked(tbl, args->csa_slotid);
next prev parent reply other threads:[~2011-11-04 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 6:39 [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug andros
2011-11-04 14:31 ` Myklebust, Trond
2011-11-04 14:34 ` Myklebust, Trond
2011-11-04 14:40 ` Bryan Schumaker [this message]
2011-11-04 14:43 ` Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB3F957.2060309@netapp.com \
--to=bjschuma@netapp.com \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).