From: Bryan Schumaker <bjschuma@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: Remove unnecessary whitespace
Date: Mon, 07 Nov 2011 09:16:09 -0500 [thread overview]
Message-ID: <4EB7E829.6020106@netapp.com> (raw)
In-Reply-To: <20111104214254.GJ721@fieldses.org>
On Fri 04 Nov 2011 05:42:54 PM EDT, J. Bruce Fields wrote:
> On Tue, Nov 01, 2011 at 02:18:28PM -0400, bjschuma@netapp.com wrote:
>> From: Bryan Schumaker <bjschuma@netapp.com>
>>
>> The close parenthesis was hard to find with it spaced so far over.
>
> What kind of terminal was Kendrick working with, anyway?
>
> If you don't mind the below as a friendly amendment, I'll queue it up
> for 3.3.
That looks like a good improvement to me.
- Bryan
>
> --b.
>
> commit 70aec307e110a2a488e10323b4d2bbd89a3f6485
> Author: Bryan Schumaker <bjschuma@netapp.com>
> Date: Tue Nov 1 14:18:28 2011 -0400
>
> NFSD: Remove unnecessary whitespace
>
> The close parenthesis was hard to find with it spaced so far over.
>
> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
> [bfields@redhat.com: get all these lines under 80 chars while we're here]
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index 4e2ee29..1d1e858 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -340,15 +340,15 @@ static inline u32 nfsd_suppattrs2(u32 minorversion)
> }
>
> /* These will return ERR_INVAL if specified in GETATTR or READDIR. */
> -#define NFSD_WRITEONLY_ATTRS_WORD1 \
> -(FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> +#define NFSD_WRITEONLY_ATTRS_WORD1 \
> + (FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
>
> /* These are the only attrs allowed in CREATE/OPEN/SETATTR. */
> -#define NFSD_WRITEABLE_ATTRS_WORD0 \
> -(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL )
> -#define NFSD_WRITEABLE_ATTRS_WORD1 \
> -(FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
> - | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> +#define NFSD_WRITEABLE_ATTRS_WORD0 \
> + (FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL)
> +#define NFSD_WRITEABLE_ATTRS_WORD1 \
> + (FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
> + | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> #define NFSD_WRITEABLE_ATTRS_WORD2 0
>
> #define NFSD_SUPPATTR_EXCLCREAT_WORD0 \
prev parent reply other threads:[~2011-11-07 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 18:18 [PATCH] NFSD: Remove unnecessary whitespace bjschuma
2011-11-04 21:42 ` J. Bruce Fields
2011-11-07 14:16 ` Bryan Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7E829.6020106@netapp.com \
--to=bjschuma@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).