* [PATCH] NFSD: Remove unnecessary whitespace
@ 2011-11-01 18:18 bjschuma
2011-11-04 21:42 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: bjschuma @ 2011-11-01 18:18 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs, Bryan Schumaker
From: Bryan Schumaker <bjschuma@netapp.com>
The close parenthesis was hard to find with it spaced so far over.
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
---
fs/nfsd/nfsd.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
index 46f97ba..7763670 100644
--- a/fs/nfsd/nfsd.h
+++ b/fs/nfsd/nfsd.h
@@ -345,7 +345,7 @@ static inline u32 nfsd_suppattrs2(u32 minorversion)
/* These are the only attrs allowed in CREATE/OPEN/SETATTR. */
#define NFSD_WRITEABLE_ATTRS_WORD0 \
-(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL )
+(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL)
#define NFSD_WRITEABLE_ATTRS_WORD1 \
(FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
| FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: Remove unnecessary whitespace
2011-11-01 18:18 [PATCH] NFSD: Remove unnecessary whitespace bjschuma
@ 2011-11-04 21:42 ` J. Bruce Fields
2011-11-07 14:16 ` Bryan Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2011-11-04 21:42 UTC (permalink / raw)
To: bjschuma; +Cc: linux-nfs
On Tue, Nov 01, 2011 at 02:18:28PM -0400, bjschuma@netapp.com wrote:
> From: Bryan Schumaker <bjschuma@netapp.com>
>
> The close parenthesis was hard to find with it spaced so far over.
What kind of terminal was Kendrick working with, anyway?
If you don't mind the below as a friendly amendment, I'll queue it up
for 3.3.
--b.
commit 70aec307e110a2a488e10323b4d2bbd89a3f6485
Author: Bryan Schumaker <bjschuma@netapp.com>
Date: Tue Nov 1 14:18:28 2011 -0400
NFSD: Remove unnecessary whitespace
The close parenthesis was hard to find with it spaced so far over.
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
[bfields@redhat.com: get all these lines under 80 chars while we're here]
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
index 4e2ee29..1d1e858 100644
--- a/fs/nfsd/nfsd.h
+++ b/fs/nfsd/nfsd.h
@@ -340,15 +340,15 @@ static inline u32 nfsd_suppattrs2(u32 minorversion)
}
/* These will return ERR_INVAL if specified in GETATTR or READDIR. */
-#define NFSD_WRITEONLY_ATTRS_WORD1 \
-(FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
+#define NFSD_WRITEONLY_ATTRS_WORD1 \
+ (FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
/* These are the only attrs allowed in CREATE/OPEN/SETATTR. */
-#define NFSD_WRITEABLE_ATTRS_WORD0 \
-(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL )
-#define NFSD_WRITEABLE_ATTRS_WORD1 \
-(FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
- | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
+#define NFSD_WRITEABLE_ATTRS_WORD0 \
+ (FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL)
+#define NFSD_WRITEABLE_ATTRS_WORD1 \
+ (FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
+ | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
#define NFSD_WRITEABLE_ATTRS_WORD2 0
#define NFSD_SUPPATTR_EXCLCREAT_WORD0 \
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: Remove unnecessary whitespace
2011-11-04 21:42 ` J. Bruce Fields
@ 2011-11-07 14:16 ` Bryan Schumaker
0 siblings, 0 replies; 3+ messages in thread
From: Bryan Schumaker @ 2011-11-07 14:16 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-nfs
On Fri 04 Nov 2011 05:42:54 PM EDT, J. Bruce Fields wrote:
> On Tue, Nov 01, 2011 at 02:18:28PM -0400, bjschuma@netapp.com wrote:
>> From: Bryan Schumaker <bjschuma@netapp.com>
>>
>> The close parenthesis was hard to find with it spaced so far over.
>
> What kind of terminal was Kendrick working with, anyway?
>
> If you don't mind the below as a friendly amendment, I'll queue it up
> for 3.3.
That looks like a good improvement to me.
- Bryan
>
> --b.
>
> commit 70aec307e110a2a488e10323b4d2bbd89a3f6485
> Author: Bryan Schumaker <bjschuma@netapp.com>
> Date: Tue Nov 1 14:18:28 2011 -0400
>
> NFSD: Remove unnecessary whitespace
>
> The close parenthesis was hard to find with it spaced so far over.
>
> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
> [bfields@redhat.com: get all these lines under 80 chars while we're here]
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index 4e2ee29..1d1e858 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -340,15 +340,15 @@ static inline u32 nfsd_suppattrs2(u32 minorversion)
> }
>
> /* These will return ERR_INVAL if specified in GETATTR or READDIR. */
> -#define NFSD_WRITEONLY_ATTRS_WORD1 \
> -(FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> +#define NFSD_WRITEONLY_ATTRS_WORD1 \
> + (FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
>
> /* These are the only attrs allowed in CREATE/OPEN/SETATTR. */
> -#define NFSD_WRITEABLE_ATTRS_WORD0 \
> -(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL )
> -#define NFSD_WRITEABLE_ATTRS_WORD1 \
> -(FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
> - | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> +#define NFSD_WRITEABLE_ATTRS_WORD0 \
> + (FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL)
> +#define NFSD_WRITEABLE_ATTRS_WORD1 \
> + (FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \
> + | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET)
> #define NFSD_WRITEABLE_ATTRS_WORD2 0
>
> #define NFSD_SUPPATTR_EXCLCREAT_WORD0 \
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-07 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 18:18 [PATCH] NFSD: Remove unnecessary whitespace bjschuma
2011-11-04 21:42 ` J. Bruce Fields
2011-11-07 14:16 ` Bryan Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).