From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: David Howells <dhowells@redhat.com>,
jmorris@redhat.com, keyrings@linux-nfs.org,
linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Keyrings] [PATCH] KEYS: Allow special keyrings to be cleared
Date: Fri, 18 Nov 2011 09:36:43 -0500 [thread overview]
Message-ID: <4EC66D7B.7030908@RedHat.com> (raw)
In-Reply-To: <20111111160753.5190.36069.stgit@warthog.procyon.org.uk>
Hey Trond,
Could you please add this patch to David's patch set?
tia,
steved.
Author: Steve Dickson <steved@redhat.com>
Date: Fri Nov 18 09:29:17 2011 -0500
KEYS: allow keys to be revoked from the keyring
To aid in cleaning up invalid id mappings add
the write bit to the key permission. Allowing
only root will be able to revoke the keys.
Signed-off-by: Steve Dickson <steved@redhat.com>
diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
index 47d1c6f..652238c 100644
--- a/fs/nfs/idmap.c
+++ b/fs/nfs/idmap.c
@@ -185,7 +185,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t nam
}
rcu_read_lock();
- rkey->perm |= KEY_USR_VIEW;
+ rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
ret = key_validate(rkey);
if (ret < 0)
next prev parent reply other threads:[~2011-11-18 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 16:07 [PATCH] KEYS: Allow special keyrings to be cleared David Howells
2011-11-11 22:41 ` Trond Myklebust
2011-11-18 14:36 ` Steve Dickson [this message]
2011-11-18 18:33 ` [Keyrings] " Trond Myklebust
2011-11-22 13:55 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC66D7B.7030908@RedHat.com \
--to=steved@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=jmorris@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).